Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEAV-118] 홈 메인 뷰 - 프로필 탭 구현 #40

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[WEAV-118] 홈 메인 뷰 - 프로필 탭 구현 #40

merged 2 commits into from
Nov 5, 2024

Conversation

jisu15-kim
Copy link
Member

@jisu15-kim jisu15-kim commented Nov 5, 2024 •
edited by coderabbitai bot
Loading

구현사항

앞으로 개선 사항(선택)

  • 배포 이후 프로필 위젯 구현 및 추가 머지 예정

Summary by CodeRabbit

  • 신규 기능

    • 홈 뷰에서 사용자 정보를 처리하는 방식이 개선되었습니다.
    • 프로필 뷰와 프로필 패널 뷰가 추가되어 사용자 프로필 정보를 표시합니다.
    • 태그 리스트 뷰의 높이를 계산하는 기능이 추가되었습니다.
    • 사용자 인증 및 애니메이션 시퀀스 관련 기능이 향상되었습니다.
    • 새로운 JSON 파일이 추가되어 이미지 자산의 메타데이터를 정의합니다.

  • 버그 수정

    • 사용자 인증 및 오류 처리 로직이 개선되었습니다.

  • 문서화

    • 새로운 파일과 메서드에 대한 설명이 추가되었습니다.

jisu15-kim and others added 2 commits November 2, 2024 18:10
@jisu15-kim
[WEAV-118] HomeMainTabView 구조 생성
0d51ec0
@jisu15-kim
[WEAV-121] 홈 - 프로필 탭 구현 (#39)
018f5ab 
* [WEAV-121] Profile Pannel View 구현

* [WEAV-121] Home Main Tab View

* [WEAV-121] 화면전화 방식 change root 로 변경

* [WEAV-121] 프로필 위젯 추가 뷰 구현
@jisu15-kim jisu15-kim added the Feature 기능 label Nov 5, 2024
@jisu15-kim jisu15-kim self-assigned this Nov 5, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2024 •
edited
Loading

Warning

Rate limit exceeded

@jisu15-kim has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 21ee044 and 018f5ab.

Walkthrough

이번 변경 사항은 여러 파일에서 사용자 정보와 관련된 기능을 개선하고, 사용자 인터페이스의 상태 관리를 강화하는 데 중점을 두었습니다. NavigationStack.swift 파일에서 .home 케이스가 userInfo 매개변수를 수용하도록 수정되었으며, SplashAnimatedView.swift에서는 홈 뷰로의 전환 시 사용자 정보를 확인하는 로직이 추가되었습니다. 여러 파일에서 새로운 모델 및 뷰가 추가되었고, 기존의 뷰와 모델은 MVI 아키텍처를 채택하여 사용자 상호작용을 관리하도록 변경되었습니다.

Changes

파일 경로 변경 요약
Projects/App/Sources/Navigation/NavigationStack.swift .home 케이스가 userInfo 매개변수를 수용하도록 변경됨.
Projects/App/Sources/Splash/SplashAnimatedView.swift pushToHomeView 함수에서 userInfo 확인 로직 추가, 비동기 호출로 변경됨.
Projects/Core/CommonKit/Sources/Path/PathTypes.swift PathType 열거형에 == 연산자와 hash(into:) 메서드 추가, home 케이스에 UserInfo 매개변수 추가.
Projects/Core/CoreKit/Sources/Int+Ext.swift Int 타입에 toString() 메서드 추가.
Projects/DesignSystem/DesignCore/Resources/Images/Images.xcassets/Profile/Contents.json 이미지 자산에 대한 메타데이터를 포함하는 JSON 파일 추가.
Projects/DesignSystem/DesignCore/Resources/Images/Images.xcassets/Profile/building_fill.imageset/Contents.json building_fill 이미지 세트에 대한 JSON 파일 추가.
Projects/DesignSystem/DesignCore/Resources/Images/Images.xcassets/Profile/business_fill.imageset/Contents.json business_fill 이미지 세트에 대한 JSON 파일 추가.
Projects/DesignSystem/DesignCore/Resources/Images/Images.xcassets/Profile/location_fill.imageset/Contents.json location_fill 이미지 세트에 대한 JSON 파일 추가.
Projects/Features/Home/Sources/HomeMain/HomeMainIntent.swift 사용자 상호작용을 관리하는 HomeMainIntent 클래스 추가, Intentable 프로토콜 정의.
Projects/Features/Home/Sources/HomeMain/HomeMainModel.swift 상태 관리를 위한 HomeMainModel 클래스 추가, HomeMainModelActionable 프로토콜 구현.
Projects/Features/Home/Sources/HomeMain/HomeMainTab.swift HomeMainTab 열거형 추가, 각 케이스에 대한 문자열 반환 프로퍼티 추가.
Projects/Features/Home/Sources/HomeMain/HomeMainView.swift HomeMainView SwiftUI 뷰 추가, 사용자 정보를 기반으로 UI 구성.
Projects/Features/Home/Sources/HomeView.swift HomeView 파일 삭제.
Projects/Features/Home/Sources/Profile/ProfileIntent.swift 사용자 프로필 상호작용을 관리하는 ProfileIntent 클래스 추가.
Projects/Features/Home/Sources/Profile/ProfileModel.swift 사용자 프로필 상태 관리를 위한 ProfileModel 클래스 추가.
Projects/Features/Home/Sources/Profile/ProfileView.swift 사용자 프로필 정보를 표시하는 ProfileView SwiftUI 뷰 추가.
Projects/Features/Home/Sources/ProfilePannel/ProfilePannelIntent.swift 프로필 패널 상호작용을 관리하는 ProfilePannelIntent 클래스 추가.
Projects/Features/Home/Sources/ProfilePannel/ProfilePannelModel.swift 프로필 패널 상태 관리를 위한 ProfilePannelModel 클래스 추가.
Projects/Features/Home/Sources/ProfilePannel/ProfilePannelView.swift 사용자 프로필 정보를 표시하는 ProfilePannelView SwiftUI 뷰 추가.
Projects/Features/SignUp/Sources/AuthSignUp/AuthPhoneVerify/AuthPhoneVerifyIntent.swift 사용자 유형에 따라 경로 변경 로직 수정.
Projects/Features/SignUp/Sources/DreamPartnerInput/DreamPartnerDistance/DreamPartnerDistanceIntent.swift 토큰 검증 로직 추가 및 경로 변경 로직 수정.
Projects/Features/SignUp/UnitTest/AuthPhoneVerifyTest.swift 테스트 케이스의 예상 결과 수정.
Projects/Model/Model/Sources/Auth/Domain/UserInfo.swift UserInfo, UserInfoProfile, DreamPartnerInfo에 대한 mock 데이터 추가.

Possibly related PRs

Suggested labels

Design

"변경의 기쁨을 노래해요,
사용자 정보가 함께해요.
홈 뷰로의 길이 열리고,
새 모델과 뷰가 함께하니,
UI가 더욱 빛나리라,
우리 함께 즐겨요, 귀여운 토끼와!" 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jisu15-kim jisu15-kim merged commit 7321184 into develop Nov 5, 2024
1 of 2 checks passed
@jisu15-kim jisu15-kim deleted the feature/WEAV-118 branch November 5, 2024 16:12
@jisu15-kim jisu15-kim restored the feature/WEAV-118 branch November 5, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jisu15-kim jisu15-kim

Labels
Feature 기능
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jisu15-kim