Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEAV-14] github action deploy config #8

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Conversation

jisu15-kim
Copy link
Member

@jisu15-kim jisu15-kim commented Sep 15, 2024

구현사항

  • 암호화 signing file 추가
  • �github repo secret 추가
  • bundle id, organization 변경
  • develop 브런치 추가시 아카이브 및 테스트플라이트 자동 배포

Summary by CodeRabbit

  • 새로운 기능
    • ExportOptions-dev.plistExportOptions-prod.plist 파일 추가로 앱 배포 옵션 정의.
  • 변경 사항
    • 앱 아이콘 세트의 이미지 항목 수를 줄이고, 1024x1024 크기의 단일 고해상도 아이콘으로 통합.
    • 조직 이름을 "com.studentcenter"에서 "com.weave"로 변경.
    • 번들 ID 형식을 업데이트하여 새로운 명명 규칙에 맞춤.

@jisu15-kim jisu15-kim self-assigned this Sep 15, 2024
Copy link
Contributor

coderabbitai bot commented Sep 15, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

이번 변경 사항은 두 개의 새로운 plist 파일(ExportOptions-dev.plistExportOptions-prod.plist)을 추가하여 앱 스토어 배포를 위한 내보내기 옵션을 정의합니다. 또한, 앱 아이콘 세트의 이미지 엔트리를 단일 항목으로 축소하고, 조직 이름 및 번들 ID를 업데이트하여 새로운 브랜드 구조에 맞추었습니다. 이러한 변경은 앱의 내보내기 및 아이콘 관리 방식을 간소화합니다.

Changes

파일 경로 변경 요약
ExportOptions-dev.plist, ExportOptions-prod.plist 두 개의 plist 파일 추가, 각각 개발 및 프로덕션 배포를 위한 내보내기 옵션 정의
Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/Contents.json 앱 아이콘 세트의 이미지 엔트리를 단일 1024x1024 아이콘으로 축소
Tuist/ProjectDescriptionHelpers/Project+extensions.swift organizationName 속성을 "com.studentcenter"에서 "com.weave"로 변경
Tuist/ProjectDescriptionHelpers/Target+extensions.swift 여러 대상 구성에 대한 bundleId 문자열을 "com.studentcenter.weave2"에서 "com.weave.three-days"로 수정

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant AppStore
    participant ExportOptions

    Developer->>ExportOptions: Configure export options
    ExportOptions->>AppStore: Submit app for review
    AppStore-->>Developer: Review status
Loading

Poem

🐰 새로운 변화가 왔네,
두 개의 plist가 빛나네.
아이콘은 단순해지고,
이름도 새롭게 바뀌었네.
우리는 함께 나아가,
더 나은 앱을 만들어가! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jisu15-kim jisu15-kim merged commit eaab965 into develop Sep 15, 2024
1 of 2 checks passed
@jisu15-kim jisu15-kim deleted the feature/WEAV-14 branch September 15, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant