-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ 유저 이상형 프로필 수정 UseCase 개발 #36
Conversation
Walkthrough이 변경 사항은 Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (3)openapi.yaml (3)
RESTful 규칙을 잘 따르고 있으며, 보안 및 에러 응답이 적절하게 정의되어 있습니다.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
openapi.yaml (1)
781-788
: 응답 스키마의 들여쓰기가 일관성이 없습니다.응답 스키마의 들여쓰기가 다른 스키마들과 일관성이 없습니다.
다음과 같이 수정하는 것을 제안드립니다:
- UpdateUserDesiredPartnerResponse: - type: object - properties: - desiredPartner: - $ref: '#/components/schemas/UserDesiredPartner' - required: - - desiredPartner + UpdateUserDesiredPartnerResponse: + type: object + properties: + desiredPartner: + $ref: '#/components/schemas/UserDesiredPartner' + required: + - desiredPartner
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
openapi.yaml
(2 hunks)
🔇 Additional comments (1)
openapi.yaml (1)
185-212
: 엔드포인트 정의가 잘 구성되어 있습니다.
API 엔드포인트가 RESTful 규칙을 잘 따르고 있으며, 보안 및 응답 정의가 체계적으로 되어 있습니다.
Summary by CodeRabbit
/users/my/desiredPartner
추가.UpdateUserDesiredPartnerRequest
및UpdateUserDesiredPartnerResponse
추가.