Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 프로필 이미지 업로드, 삭제, 조회 API 추가 #38

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

waterfogSW
Copy link
Member

@waterfogSW waterfogSW commented Dec 7, 2024

Summary by CodeRabbit

  • 새로운 기능

    • 사용자 프로필 이미지 삭제를 위한 새로운 API 엔드포인트 추가 (/users/my/profile-images/{imageId}).
    • 사용자 프로필 정보 응답에 profileImages 속성 추가, 프로필 이미지의 세부 정보 제공.
    • 프로필 이미지 업로드 요청 시 extension 속성 필수화.
  • 개선 사항

    • 프로필 이미지 관리 기능 향상 및 사용자 프로필 쿼리의 정보 개선.

Copy link

coderabbitai bot commented Dec 7, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

이 PR은 openapi.yaml 파일에 대한 여러 가지 수정을 도입하여 사용자 프로필 관리 및 인증 기능을 개선합니다. 새로운 엔드포인트 /users/my/profile-images/{imageId}가 추가되어 사용자가 특정 프로필 이미지를 ID로 삭제할 수 있게 되며, 이 엔드포인트는 DELETE 메서드를 사용하고 imageId라는 필수 경로 매개변수를 포함합니다. 또한, GetMyUserInfoResponse의 응답 스키마가 업데이트되어 profileImages라는 새로운 속성이 추가되었습니다.

Changes

파일 경로 변경 요약
openapi.yaml - 새로운 엔드포인트 /users/my/profile-images/{imageId} 추가 (삭제 기능)
- GetMyUserInfoResponse 스키마에 profileImages 속성 추가
- 새로운 ProfileImage 스키마 추가
- CompleteProfileImageUploadRequest 스키마에 extension 속성 필수화

Possibly related PRs

Suggested labels

fix

Suggested reviewers

  • dojinyou
  • moondev03
  • jisu15-kim

Poem

🐰 프로필 이미지 삭제, 새로 생긴 길,
유저 정보에 더 많은 이야기, 참 기쁨이네.
확장자도 잊지 말고, 업로드 완성,
모두 함께하는 이 변화, 즐거운 순간! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4768665 and b0457c3.

📒 Files selected for processing (1)
  • openapi.yaml (4 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@waterfogSW waterfogSW changed the title Fix/profile image ✨ 프로필 이미지 업로드, 삭제, 조회 API 추가 Dec 7, 2024
@waterfogSW waterfogSW self-assigned this Dec 7, 2024
@waterfogSW waterfogSW merged commit b4118d6 into main Dec 7, 2024
2 of 3 checks passed
@waterfogSW waterfogSW deleted the fix/profile-image branch December 7, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant