Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit #902

Closed
Closed

Conversation

Damini2004
Copy link

Related Issue

#801
#801

Description

Language translator has been implemeted successfully. Kindly review it.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

AgriLearnNetwork-and-2-more-page.mp4

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Kinldy review it and add relevent level to the PR.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@Suchitra-Sahoo
Copy link
Owner

Everything in navbar has got mixed up. The language changing option should look similar to other navbar options. Keep only indian languages.

@Damini2004
Copy link
Author

@Suchitra-Sahoo Yes for that we have alter some changes in css file for alignment.
For similarity it will be achieved in next commit.
As it is Provided by google so all language are inlcuded so in order to customize the language as per your point of view then it will more lengthy.

@Suchitra-Sahoo
Copy link
Owner

Okay but then this feature will not be useful for the website. I am attaching an example where you can see that there are only few specific languages and the option is matching with navbar too.
image

@Suchitra-Sahoo
Copy link
Owner

So inform me whether you will be able to create something like this or not.

@Damini2004
Copy link
Author

@Suchitra-Sahoo Yes i can customize the types of language, that it will consist of indian native languages.
I can style the navbar in proper manner.
@Suchitra-Sahoo

@Damini2004
Copy link
Author

image

gothrough it

@Suchitra-Sahoo
Copy link
Owner

Try to make something as provided by me in previous image bcs the second one is very simple and will look totally different in navbar.

@Damini2004
Copy link
Author

@Suchitra-Sahoo Its just the image depicts that i can integrate the native indian languages i will add more styling to it.
Kinldy open the issue i want to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants