Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Compilation Albums; various character issues. #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle Compilation Albums; various character issues. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions classify_mp3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,36 +56,52 @@ def get_data_from_filename(file_path):
if artist is None:
artist = filename_infos.get("artist")

# For compilation albums
if id3.album_artist == "Various Artists":
artist = "Various Artists"

# format name only if only standard chars (don't want to rename V▲LH▲LL)
if re.match(r'^[ a-zA-Z0-9_-]+$', artist):
artist = artist.title()

album = id3.album
if album is None:

if id3.album is not None:
album = re.sub("[<>:\"/\|?*]", "_", id3.album)
else:
album = filename_infos.get("album")

year = str(id3.getBestDate())

title = id3.title
if title is None:
if id3.title is not None:
title = re.sub("[<>:\"/\|?*]", "_", id3.title)
else:
title = filename_infos.get("title")

track_num = id3.track_num

album = (f"({year}) " if year is not None else "") + album
if album is None or album == "":
album = (f"({year})" if year is not None else "")
else:
album = (f"({year}) " if year is not None else "") + re.sub("[<>:\"/\|?*]", "_", album)

filename = f"{track_num[0]:02} - " if track_num is not None else ""
filename = f"{filename}{title}.mp3".replace(os.path.sep, "-")

# try to handle long names
if len(filename) > 64:
filename = filename[0:60] + '.mp3'

# Create directories & file
dir_path = os.path.join(FILES_DIR, artist, album)
file_path = os.path.join(dir_path, filename)

pathlib.Path(dir_path).mkdir(parents=True, exist_ok=True)
os.rename(mp3_path, file_path)

print(f"{mp3_path} moved to {file_path}")

try:
os.rename(mp3_path, file_path)
except FileNotFoundError:
print(f"couldn't move {mp3_path.encode('cp1252', errors='ignore')}, maybe the resulting filename will be too long for Windows'")

print(f"{mp3_path.encode('cp1252', errors='ignore')} moved to {file_path.encode('cp1252', errors='ignore')}")

print("Sorting MP3 files done.")

print("Removing .csv file.")
Expand Down