Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bl): fix createbucketpolicy with download permission #731

Merged

Conversation

mahadi99xy
Copy link
Collaborator

🚧 Suggest a change

A clear and concise description of what you are changing.

📝 Pre-merge checklist

Ready to merge? Do not merge until all checks are satisfied.

  • 💹 Have all required CI checks passed on the most recent commit?
  • ✒️ Is the PR title a valid and meaningful conventional-commit message? ie. type(scope): summary
  • 💥 Are breaking changes declared in the PR title in conventional-commit style? ie. type!(scope): summary
  • 🎨 Does new code follow the code style of this project?
  • 🔍 Has new code been spellchecked and linted?
  • 📖 Have docs been updated where necessary?
  • 💩 Have commits been checked for accidental file inclusions?

Copy link

✒️ PR Title Commitlint - ❌ Lint error! Fix title before merging!

Expected PR title to be conventional commit format: ie. type(scope): summary

⧗   input: fix(bl): fix createbucketpolicy with download permission
✖   scope must be one of [, deps, egress-api-container, egress-ui-container, main-api-container, main-ui-container, tre-api-container, tre-ui-container, tre-hasura-container, tre-sql-pg-container, tre-sql-trino-container] [scope-enum]

✖   found 1 problems, 0 warnings
ⓘ   Get help: .github/commitlint.config.mjs

Conventional Commits 📖 Docs
Commitlint 🗄️ Config 📖 Docs

@jaybeeelsdon jaybeeelsdon merged commit 759dcef into main Jul 22, 2024
11 of 12 checks passed
@jaybeeelsdon jaybeeelsdon deleted the fix/fix-createbucketpolicy-with-download-permission branch July 22, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants