[WIP][PoC] add behat to github actions #71
Conversation
oallain
commented
Jul 26, 2020
oallain
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | yes |
| Deprecations? | yes |
| Related tickets | partially #60 |
| License | MIT |
.github/workflows/behat.yaml
Outdated
| working-directory: ./sylius | ||
| run: | | ||
| echo "const bootstrapTheme = require('./themes/BootstrapTheme/webpack.config');" >> webpack.config.js | ||
| echo "module.exports = [bootstrapTheme];" >> webpack.config.js |
There was a problem hiding this comment.
Does this not leave us with 2 "module.exports = .." lines in the webpack.config.js file? I think this would override the previous assignment containing the shop and admin exports.
| - name: Composer - Github Auth | ||
| run: composer config -g github-oauth.github.com ${{ github.token }} | ||
|
|
||
| - name: Composer - Install Sylius-Standard |
There was a problem hiding this comment.
There are a lot of similarities with what's happening in the Dockerfile of #66 here.
oallain
force-pushed
the
github-actions-behat
branch
from
98b51d9 to
6e1055a
Compare
oallain
force-pushed
the
github-actions-behat
branch
20 times, most recently
from
dd487e0 to
f090143
Compare
oallain
force-pushed
the
github-actions-behat
branch
from
f090143 to
55bf208
Compare
|
Please keep in mind that currently when you run behat, you're just running the tests against the standard sylius version, without the theme, as that is controlled in the scenarios themselves. I don't see any code where you're overriding anything to make sure the right theme is selected for the channel that is used in the tests, or are somehow updating the channel that is added by the tests. Also wouldn't it be good to run the tests in the container setup? That way development and testing can be done in the exact same environment, no matter what system is being used... Preventing the whole "works on my machine" syndrome. |
|
Hello @4c0n Thanks for feedbacks.
I forced
We can do that, yes. But I would like to make them work like this already, and then we can use a custom container. Regards, |
|
@oallain ah I missed that part. Someone came up with this solution: https://gist.github.com/anthid/dcc214804354c8d81013453d83aa219f Sure the containers can come later. |
