Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Incinerator #300

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Add the Incinerator #300

merged 7 commits into from
Jan 14, 2025

Conversation

bruberu
Copy link
Member

@bruberu bruberu commented Aug 29, 2024

image
image
This singleblock is a supplement to the IR incinerator block, and goes up to EV tier, which incinerates 2 items per tick.
Also fixes the roaster bottom texture.

@MCTian-mi
Copy link
Collaborator

MCTian-mi commented Sep 5, 2024

issues found in my testing:

  • incinerator don't get render updates properly when they start/stop working, or when their working state is set to enbled/disabled (due to being clogged).
  • they don't go back to work when the block that clogged them is removed (probably because they stopped doing update(), since their working state are set to disabled when they get clogged.

@MCTian-mi
Copy link
Collaborator

maybe we should make incinerator a pseudo multi with 8 air() above it

@MCTian-mi
Copy link
Collaborator

also maybe not a big issue but imo some more but slower smoke particle could look better(?)

# Conflicts:
#	src/main/java/supersymmetry/common/metatileentities/SuSyMetaTileEntities.java
@bruberu
Copy link
Member Author

bruberu commented Jan 9, 2025

This PR should be ready for rereview.

@MCTian-mi
Copy link
Collaborator

MCTian-mi commented Jan 10, 2025

  • they don't go back to work when the block that clogged them is removed (probably because they stopped doing update(), since their working state are set to disabled when they get clogged.

this issue still presents
probably doesn't matter that much tho
besides that this works fine for me

Technically, I already am limiting the number of clog-checks, so I might as well do this.
@bruberu
Copy link
Member Author

bruberu commented Jan 14, 2025

Alright, after testing the minor modifications I made to address concerns, I think this can be merged.

@bruberu bruberu merged commit f7b241d into main Jan 14, 2025
1 check passed
@bruberu bruberu deleted the bru-landfill branch January 14, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants