Fix stata deposit for new account (#141)

Synthetixio · Jan 10, 2025 · 9495ca2 · 9495ca2
1 parent adc3945
commit 9495ca2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/liquidity/components/DepositModal/StataDepositModal.tsx b/liquidity/components/DepositModal/StataDepositModal.tsx
@@ -115,10 +115,11 @@ export function StataDepositModal({
   //Preparing stataUSDC Done
 
   //Stata Approval
-  const stataApprovalNeeded =
-    liquidityPosition && liquidityPosition.availableCollateral.lt(collateralChange)
+  const stataApprovalNeeded = liquidityPosition
+    ? liquidityPosition.availableCollateral.lt(collateralChange)
       ? collateralChange.sub(liquidityPosition.availableCollateral)
-      : wei(0);
+      : wei(0)
+    : collateralChange;
   const { approve: approveStata, requireApproval: requireApprovalStata } = useApprove({
     contractAddress: synthToken?.token?.address,
     amount:
@@ -144,8 +145,8 @@ export function StataDepositModal({
     newAccountId,
     collateralTypeAddress: synthToken?.token?.address,
     collateralChange,
-    currentCollateral: liquidityPosition?.collateralAmount,
-    availableCollateral: liquidityPosition?.availableCollateral,
+    currentCollateral: liquidityPosition ? liquidityPosition.collateralAmount : wei(0),
+    availableCollateral: liquidityPosition ? liquidityPosition.availableCollateral : wei(0),
     collateralSymbol: params.collateralSymbol,
   });
   //Deposit done
@@ -257,10 +258,6 @@ export function StataDepositModal({
 
       [ServiceNames.executeDeposit]: async () => {
         try {
-          if (!liquidityPosition) {
-            throw Error('Deposit failed: not ready');
-          }
-
           toast.closeAll();
           toast({
             title: Boolean(params.accountId)
@@ -271,8 +268,8 @@ export function StataDepositModal({
           });
 
           setTxSummary({
-            currentCollateral: liquidityPosition.collateralAmount,
-            currentDebt: liquidityPosition.debt,
+            currentCollateral: liquidityPosition ? liquidityPosition.collateralAmount : wei(0),
+            currentDebt: liquidityPosition ? liquidityPosition.debt : wei(0),
             collateralChange,
           });
 

diff --git a/liquidity/lib/useDepositBaseAndromeda/useDepositBaseAndromeda.tsx b/liquidity/lib/useDepositBaseAndromeda/useDepositBaseAndromeda.tsx
@@ -149,12 +149,10 @@ export const useDepositBaseAndromeda = ({
         ethers.utils.parseEther('1')
       );
 
-      const callsPromise = Promise.all(
+      const calls = await Promise.all(
         [wrap, synthApproval, createAccount, deposit, delegate].filter(notNil)
       );
 
-      const [calls] = await Promise.all([callsPromise]);
-
       if (priceUpdateTx) {
         calls.unshift(priceUpdateTx as any);
       }