Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/small obj allocator #3301

Draft
wants to merge 2 commits into
base: community
Choose a base branch
from

Conversation

m-m-adams
Copy link
Collaborator

Made the alignment info into class members instead of global constants in order to allow creating an extra region for small objects (e.g. strings, maybe other stuff) that don't fit the same allocation pattern as non stealable song and audio data

Also make the cache manager optional since stealables are only allocated in one region. I think branching on whether there's a cache manager is better than using a virtual reclaim memory function but that's just gut feel

todo: actually creating the extra region

Copy link
Contributor

Test Results

107 tests  ±0   107 ✅ ±0   1s ⏱️ -1s
 16 suites ±0     0 💤 ±0 
 16 files   ±0     0 ❌ ±0 

Results for commit 8938f27. ± Comparison against base commit d37eb1f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant