This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
feat: add validation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwlee
commented
Mar 29, 2024
ethanwlee
commented
Mar 29, 2024
lib/src/protocol/models/message.dart
Outdated
Comment on lines
81
to
82
| // TODO: how to initialize properly? | ||
| await Validator.initialize(); |
There was a problem hiding this comment.
would like a better solution for initializing Validator... any ideas?
There was a problem hiding this comment.
You beat me to it, I was just about to suggest possibly using a singleton with a static constructor. Nice work!
wesbillman
approved these changes
Apr 1, 2024
Comment on lines
+18
to
+30
| - name: Init Hermit | ||
| uses: cashapp/activate-hermit@v1 | ||
| with: | ||
| cache: true | ||
|
|
||
| - name: Install Dependencies | ||
| run: just get | ||
|
|
||
| - name: Run Static Analysis | ||
| run: just analyze | ||
|
|
||
| - name: Run Tests | ||
| run: just test |
Comment on lines
67
to
79
| final jsonResource = jsonDecode(payload) as Map<String, dynamic>?; | ||
| if (jsonResource == null) { | ||
| throw Exception('payload is not a valid JSON object'); | ||
| } | ||
| Validator.validate(jsonResource, 'resource'); | ||
|
|
||
| final jsonResourceData = jsonResource['data']; | ||
| final resourceMetadata = jsonResource['metadata'] as ResourceMetadata?; | ||
| if (resourceMetadata == null) { | ||
| throw Exception('metadata property is required'); | ||
| } | ||
| final resourceKind = resourceMetadata.kind.name; | ||
| Validator.validate(jsonResourceData, resourceKind); |
There was a problem hiding this comment.
This logic seems duplicated, would it be better to put it in a class that can be parsed with data and metadata?
There was a problem hiding this comment.
will make sure to cover this in #6!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #2
parse()tbdexsubmodule (inspired by tbdex-js)verifyOfferingRequirements()inrfq.dart(except verifying the claims)also adds ci