Pass the Execution Space as TT template parameter #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaults to Host execution so existing code is not affected. Properly set by make_tt. We cannot query TT::derivedT for flags because at the time TT is instantiated because derivedT is incomplete at that point. For now pass the Space as template parameter. We need to find a different way if we want to have multiple implementations of a task. Signed-off-by: Joseph Schuchart <joseph.schuchart@stonybrook.edu>
devreal
force-pushed
the
execution-space-as-template-param
branch
from
fda2d8a to
29af994
Compare
|
Please review, this is needed for #301 to pass CI. |
With ICLDisco/parsec#694 PaRSEC will have a proper initializer for gpu task structures but until then we need to properly initialize this field to something non-zero. Signed-off-by: Joseph Schuchart <joseph.schuchart@stonybrook.edu>
evaleev
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults to Host execution so existing code is not affected. Properly set by make_tt.
We cannot query TT::derivedT for flags because at the time TT is instantiated because derivedT is incomplete at that point. For now pass the Space as template parameter. We need to find a different way if we want to have multiple implementations of a task.