Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impr/contest manage UI #103

Open
wants to merge 3 commits into
base: v2.0
Choose a base branch
from
Open

Conversation

eran0926
Copy link

In this PR, we make some features and improvements about contest.

Features

  • add show_confirm_dialog function to index.js
  • show confirm for remove action in contest problem manage page

Improvements

  • swap the positions and colors of rechal and remove btn

eran0926 and others added 3 commits December 18, 2024 00:54
Copy link
Collaborator

@LifeAdventurer LifeAdventurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on implementing the confirmation dialog!

I noticed that the HTML for the modal dialog is directly embedded in the JavaScript file. To maintain a clean separation of concerns and improve maintainability, I recommend migrating the modal dialog's HTML structure to a dedicated HTML file.

This will:

  • Make the codebase easier to manage, especially as the HTML structure evolves.
  • Allow frontend developers to edit or style the modal without digging into JavaScript files.
  • Improve readability by keeping JavaScript focused on logic and interactivity.

Please consider refactoring this implementation to load the modal HTML from an external source or reuse existing markup in the HTML file.

Looking forward to your updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants