-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Broken Docs Links #221
base: main
Are you sure you want to change the base?
Conversation
Documentation available at: |
As suspected, last night's build woes had to do with the release of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the one identified broken link. Not sure what the others are that are alluded to in the issue. Given that this link re-writing is fairly fragile, would it be possible to add CI to check links?
There were a few additional broken links on the same page - the following link definitions were all functioning in the original CONTRIBUTING.md but nonfunctioning in the built + published Development page because that page utilized
I checked each of the other docs pages and didn't find instances of the same issue.
I agree that we should add a CI check that crawls the docs site and checks for 404s among links. My spare time to contribute to TIDES is pretty limited at the moment and I can't tackle that immediately, so is it alright with you if I document that idea via a new Issue and merge this set of changes, @botanize? EDIT: realized the |
💯
I don't know the process anymore either, probably easiest to check with @jlstpaul. |
Resolves #209 by updating the dictionary of link substitutions referenced during docs generation (which is used in our setup because we
include_file
in various places where the included file sits at a different folder level than the file it's included within). Also makes a couple small copy edits, where found.I did a quick click-through of links within the docs site on this branch to see if there were any additional broken links beyond the ones already identified on the Development page, and did not find any.