SoapySDR: Support multiple gains #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoapySDR has a function called setGainElement() that allows users to specify gains for different hardware components (e.g., for HackRF, the preamp, the LNA, and the VGA. Currently acarsdec calls setGain(double) which asks the driver to distribute the gain number to different components, which sometimes may not be desired. This patch enables the new cmd syntax of `-g name:gain -g name:gain ...` that allows users to set different gains for different components. This patch preserves compatibility with the previous syntax `-g gain`. It conflicts with the previous syntax. The user has to choose between `-g gain` (use setGain(), supports AGC) or `-g name:gain -g name:gain ...` (use setGainElement(), does not support AGC). This patch is for SoapySDR only.
Trumeet
force-pushed
the
patch_soapy_multi_gain
branch
from
e504ae9 to
ac0d199
Compare
|
|
Supported gain names:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoapySDR has a function called setGainElement() that allows users to specify gains for different hardware components (e.g., for HackRF, the preamp, the LNA, and the VGA.
Currently acarsdec calls setGain(double) which asks the driver to distribute the gain number to different components, which sometimes may not be desired.
This patch enables the new cmd syntax of
-g name:gain -g name:gain ...that allows users to set different gains for different components.This patch preserves compatibility with the previous syntax
-g gain. It conflicts with the previous syntax. The user has to choose between-g gain(use setGain(), supports AGC) or-g name:gain -g name:gain ...(use setGainElement(), does not support AGC)." -m "This patch is for SoapySDR only.