Fix System Default theme not listening to system theme change #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupaschoal
force-pushed
the
follow-system-theme
branch
from
df5f45f to
a4718b4
Compare
araujoarthur0
approved these changes
Dec 26, 2024
|
\changelog-update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Somewhat related to #879
Context / Background
Upon reviewing #1080 I noticed that we could take the chance to start listening for the system theme changes to update the app on the fly.
What change is being introduced by this PR?
The app will now listen for system theme changes and reload the theme.
How will this be tested?
Tested manually, see the video:
system-follow.mp4