Some more sentry noise fixes (#1151)

* chore: add regex patterns for errors to ignore in sentry config

* fix: handle unhandled promise rejection in substrate connections

* fix: revert last and make throwAfter reject with a real Error object

* fix: catch and emit error in websocket connection, when response is not JSON

* chore: changeset

* fix: handle error states arising from change to throwAfter function

* fix: improve error handling in Websocket

* chore: changeset

.changeset/long-toys-act.md

@@ -0,0 +1,5 @@
+---
+"@talismn/chain-connector": patch
+---
+
+Improved error handling in Websocket connector

.changeset/quiet-papayas-cheat.md

@@ -0,0 +1,6 @@
+---
+"@talismn/chain-connector": patch
+"@talismn/util": patch
+---
+
+Error handling improvements

apps/extension/src/core/config/sentry.ts

@@ -22,6 +22,10 @@ export const initSentry = (sentry: typeof SentryBrowser | typeof SentryReact) =>
     release: process.env.RELEASE,
     sampleRate: 1,
     maxBreadcrumbs: 20,
+    ignoreErrors: [
+      /(No window with id: )(\d+).?/,
+      /(disconnected from wss)[(]?:\/\/[\w./:-]+: \d+:: Normal Closure[)]?/,
+    ],
     // prevents sending the event if user has disabled error tracking
     beforeSend: async (event) => ((await firstValueFrom(useErrorTracking)) ? event : null),
     // eslint-disable-next-line @typescript-eslint/no-unused-vars

apps/extension/src/core/domains/ethereum/handler.tabs.ts

@@ -337,6 +337,7 @@ export class EthTabsHandler extends TabsHandler {
             client.request({ method: "eth_chainId" }),
             throwAfter(10_000, "timeout"), // 10 sec timeout
           ])
+          assert(!!rpcChainIdHex, `No chainId returned for ${rpcUrl}`)
           const rpcChainId = hexToNumber(rpcChainIdHex)
 
           assert(rpcChainId === chainId, "chainId mismatch")

apps/extension/src/core/domains/transactions/watchEthereumTransaction.ts

@@ -4,6 +4,7 @@ import { log } from "@core/log"
 import { createNotification } from "@core/notifications"
 import { chainConnectorEvm } from "@core/rpcs/chain-connector-evm"
 import { chaindataProvider } from "@core/rpcs/chaindata"
+import { assert } from "@polkadot/util"
 import * as Sentry from "@sentry/browser"
 import { EvmNetworkId } from "@talismn/chaindata-provider"
 import { sleep, throwAfter } from "@talismn/util"
@@ -57,6 +58,7 @@ export const watchEthereumTransaction = async (
         throwAfter(5 * 60_000, "Transaction not found"),
       ])
 
+      assert(receipt, "Transaction to watch not found")
       // check hash which may be incorrect for cancelled tx, in which case receipt includes the replacement tx hash
       if (receipt.transactionHash === hash) {
         // to test failing transactions, swap on busy AMM pools with a 0.05% slippage limit

apps/extension/src/ui/hooks/ledger/useLedgerEthereum.ts

@@ -53,6 +53,7 @@ export const useLedgerEthereum = (persist = false) => {
         ledger.getAddress(getEthLedgerDerivationPath("LedgerLive")),
         throwAfter(5_000, "Timeout"),
       ])
+
       const { version } = await ledger.getAppConfiguration()
       if (!gte(version, LEDGER_ETHEREUM_MIN_VERSION))
         throw new LedgerError("Unsupported version", "UnsupportedVersion")

packages/chain-connector/src/Websocket.ts

@@ -460,12 +460,15 @@ export class Websocket implements ProviderInterface {
 
   #onSocketMessage = (message: MessageEvent<string>): void => {
     // log.debug(() => ["received", message.data])
+    try {
+      const response = JSON.parse(message.data) as UnknownJsonRpcResponse
 
-    const response = JSON.parse(message.data) as UnknownJsonRpcResponse
-
-    return isUndefined(response.method)
-      ? this.#onSocketMessageResult(response)
-      : this.#onSocketMessageSubscribe(response)
+      return isUndefined(response.method)
+        ? this.#onSocketMessageResult(response)
+        : this.#onSocketMessageSubscribe(response)
+    } catch (e) {
+      this.#emit("error", new Error("Invalid websocket message received", { cause: e }))
+    }
   }
 
   #onSocketMessageResult = (response: UnknownJsonRpcResponse): void => {

packages/util/src/throwAfter.ts

@@ -1,2 +1,2 @@
 export const throwAfter = (ms: number, reason: string) =>
-  new Promise<never>((_, reject) => setTimeout(() => reject(reason), ms))
+  new Promise<void>((_, reject) => setTimeout(() => reject(new Error(reason)), ms))