Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OP stack L1 fees #1128

Closed
wants to merge 2 commits into from
Closed

feat: OP stack L1 fees #1128

wants to merge 2 commits into from

Conversation

0xKheops
Copy link
Contributor

@0xKheops 0xKheops commented Oct 24, 2023

Wallet :

  • For OP stack chains (OP, Zora, Base), account for the L1 Data Fee when displaying estimates and check for enough balance
  • Display L2 specifics on tx sign view details pane

Playground :

  • Bump wagmi version
  • Replace ethers by viem
  • Add Base to the EVM chains dropdown

Notes :

  • Arbitrum family chains do not require tuning, they bump the estimated gas to account for the L1 cost
  • Polygon PoS has it's own native token, L1 cost management is managed under the hood
  • Ideally we would add a isOpStackL2 flag to evm networks in chain data, but i'd prefer to delay this until we use the new (static) chaindata

@0xKheops 0xKheops changed the title Feat/l1 fees feat: OP stack L1 fees Oct 24, 2023
@0xKheops 0xKheops requested a review from chidg October 24, 2023 08:07
@0xKheops 0xKheops marked this pull request as draft November 1, 2023 01:56
@0xKheops
Copy link
Contributor Author

0xKheops commented Nov 1, 2023

on hold because of viem migration

@0xKheops
Copy link
Contributor Author

0xKheops commented Nov 8, 2023

replaced by #1146

@0xKheops 0xKheops closed this Nov 8, 2023
@0xKheops 0xKheops deleted the feat/l1-fees branch November 8, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EVM L2
1 participant