Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset display in popup fixes #1169

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Asset display in popup fixes #1169

merged 2 commits into from
Dec 4, 2023

Conversation

chidg
Copy link
Contributor

@chidg chidg commented Dec 1, 2023

Fixes a few issues:

  • selected account was not being properly selected in the popup, due to having two ways of managing selected account state. This PR consolidates both methods into one; in the popup, the selected account is now always determined by url parameters, while in the full screen, it's stored in a setting. This fixes the issue caused by this problem where all default tokens (DOT, KSM, ETH) would be displayed in empty accounts.
  • when hideDust is true, this PR prevents the default tokens from being hidden in an empty account

@chidg chidg enabled auto-merge (squash) December 1, 2023 07:07
@chidg chidg requested review from alecdwm and 0xKheops December 1, 2023 07:08
alecdwm
alecdwm approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@alecdwm alecdwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chidg chidg merged commit 76b4f64 into dev Dec 4, 2023
4 checks passed
@chidg chidg deleted the fix/asset-display-popup branch December 4, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecdwm alecdwm alecdwm approved these changes

@0xKheops 0xKheops Awaiting requested review from 0xKheops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chidg @alecdwm