Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use type import for types only library #1182

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

tien
Copy link
Contributor

@tien tien commented Dec 8, 2023

This was causing build failure on the latest version of Vite

Copy link
Contributor

github-actions bot commented Dec 8, 2023

🦋 Changeset(s) detected

This PR includes changeset(s) for the following changed packages:

"@talismn/chaindata-provider-extension"

Not sure what this means? Click here to learn what changesets are.

@tien tien force-pushed the refactor/use-correct-type-import branch from db66518 to 4a3dad7 Compare December 8, 2023 02:14
This was causing build failure on the latest version of Vite
@tien tien force-pushed the refactor/use-correct-type-import branch from 4a3dad7 to a913e02 Compare December 8, 2023 02:16
Copy link
Member

@alecdwm alecdwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tien tien merged commit 776432e into dev Dec 8, 2023
4 checks passed
@tien tien deleted the refactor/use-correct-type-import branch December 8, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants