Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/ramp modal #1780

Merged
merged 104 commits into from
Jan 17, 2025
Merged

Feat/ramp modal #1780

merged 104 commits into from
Jan 17, 2025

Conversation

UrbanWill
Copy link
Contributor

@UrbanWill UrbanWill commented Jan 12, 2025 •
edited
Loading

Description

⚠️ Depends on:

https://github.com/TalismanSociety/talisman-config/pull/10

Add new route for buy and selling tokens with Ramp. Remove old on ramp components.

🖼️ Screenshots:

Screen.Recording.2025-01-13.at.16.34.43.mov

@UrbanWill
feat: add ramp routes
fa0dcbc
@UrbanWill
feat: initial BuyForm setup
815adea
@UrbanWill
feat: added NumberInputWithDropdown component
6a0a845
@UrbanWill
feat: getRampCurrencies, add ramp base path to env
ddbd15f
@UrbanWill
feat: consume useGetRampCurrencies, update form
c2d827d
@UrbanWill
feat: added useGetRampAssetsByCurrency, updated buy form
931e0f5
@UrbanWill
feat: debounced amount inputs to fetch up to date quotes
f55969a
@UrbanWill
feat: update token/fiat based on form interaction
726b443
@UrbanWill
feat: select account UI
77ca542
@UrbanWill
chore: added RAMP base path, path and api to env vars
749ed41
@UrbanWill
feat: create url params and navigate on submit
e17b82f
@UrbanWill
feat: format token plank before external navigation
f86ca1d
@UrbanWill
feat: move ramp routes to Portfolio routes and layout
09d23cf
@UrbanWill
feat: added missing UI for NumberInputWithDropDown
6de5d8b
@UrbanWill
feat: added RampAccountOption
24b42c0
@UrbanWill
feat: off ramp form
949dcea
@UrbanWill
feat: offramp assets hook
774e91e
@UrbanWill
feat: added ramp to popup routes
a74fb3a
@UrbanWill
feat: added ramp ui to popup
ca0333c
@UrbanWill
fix: dropdown overflow on popup view
5cf6879
@UrbanWill
chore: pulled dev and solved conflicts
7add807
@UrbanWill
fix: selected token should match chain
04994fb
@UrbanWill
feat: fetch ramp quote based on fiat or token amount
57f9720
@UrbanWill
feat: bi-directional onramp quote
780faa1
@UrbanWill
feat: bi-directional offramp quote
dcb1737
@UrbanWill
fix: handle unsupported tokens when switching between buy/sell forms
cb646b4
@UrbanWill
feat: searchable Dropdown
16873eb
@UrbanWill
feat: step decimals, throw error if bad quote, cleanup
9dcf4a3
@UrbanWill
fix: searchInput import
fe3fa2d
@UrbanWill
feat: select button placeholder
6002ac3
@UrbanWill UrbanWill mentioned this pull request Jan 13, 2025
Closed
@UrbanWill UrbanWill marked this pull request as ready for review January 13, 2025 09:47
@UrbanWill UrbanWill requested review from alecdwm, chidg and 0xKheops and removed request for alecdwm January 13, 2025 09:47
@UrbanWill UrbanWill requested a review from chidg January 14, 2025 09:10
0xKheops
0xKheops approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@0xKheops 0xKheops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@chidg chidg merged commit f792c4b into dev Jan 17, 2025
6 checks passed
@chidg chidg deleted the feat/ramp-modal branch January 17, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xKheops 0xKheops 0xKheops approved these changes

@alecdwm alecdwm Awaiting requested review from alecdwm

@chidg chidg Awaiting requested review from chidg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UrbanWill @chidg @0xKheops