WIP: Fix for sync crash; Simplified pouchDbSyncOptions #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added pending to sync progress output
Different options for push and pull sync. Hard coded localPouchOptions since to 0.
guardrail for sync-protocol-2 deployments. Storing different last_seq for push/pull in sync. Re-instated the option for using $or and a big list of forms.
|
Moved from 3.8.1 PR - #2015 - there are more relevant comments in that PR. |
Added sync direction Separate push/pull pouchdb sync options
Not using appConfig.couchdbSync4All.
Implemented caching for tangerine-build-id and tangerine-build-channel
better for mobile devices w/ less memory.
This was referenced Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pending to sync progress output
Description
This is a work-around for memory issues when syncing with the Cordova-Sqlcipher plugin
Type of Change
Proposed Solution
I simplified the code for creating the selector in the mango query. If a site is using 2-way sync, we are recommending syncing all forms; therefore, I removed the code that builds a very long $or statement.
Before the sync, the code checks for sync-checkpoint, which is populated during the first sync.
Limitations and Trade-offs
This code ignores any settings in Sync Configuration; instead, it syncs all forms. There is no checking of the couchdbSyncSettings.enabled property in each formInfo.
Also, after this sync process is done, the code progresses to this.syncCustomService.sync and does a push of most of the docs that were just synced (marked as customSyncSettings enabled and push). Note it is not a sync, using the changes feed, but instead a push using the doc _id's. Wouldn't it be better to do a couch sync instead? One thing the customSyncSettings can do is remove a field's value if a field is marked as private.