New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed One-to-one property of logs in EL3, EL5, and EL6 #430 #470

Open

tdegeorge wants to merge 20 commits into main from Tonya-Issue-430

+122 −40

Contributor

tdegeorge commented Dec 17, 2024

Fixed #430

tdegeorge added 3 commits

December 17, 2024 00:29


          FN5 addition #332

b1f17b2


          Added in an application example at the end

33b0aee


          Fixed One-to-one property of logs in EL3, EL5, and EL6 #430

04ae0f3

github-actions bot deployed to tbil (Preview)

December 17, 2024 02:11

View deployment

github-actions bot commented Dec 17, 2024

🚀 Preview available 🚀

https://f7133deb.tbil.pages.dev

source/precalculus/source/02-FN/05.ptx: https://f7133deb.tbil.pages.dev/preview/precalculus/instructor/FN5.html
source/precalculus/source/05-EL/03.ptx: https://f7133deb.tbil.pages.dev/preview/precalculus/instructor/EL3.html
source/precalculus/source/05-EL/05.ptx: https://f7133deb.tbil.pages.dev/preview/precalculus/instructor/EL5.html
source/precalculus/source/05-EL/06.ptx: https://f7133deb.tbil.pages.dev/preview/precalculus/instructor/EL6.html

tdegeorge added the precalculus label

siwelwerd requested a review from AbbyANoble

December 17, 2024 17:36

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved


          Update source/precalculus/source/05-EL/05.ptx

7a06908

github-actions bot deployed to tbil (Preview)

December 17, 2024 20:37

View deployment

github-actions bot commented Dec 17, 2024

🚀 Preview available 🚀

https://eae803db.tbil.pages.dev

source/precalculus/source/02-FN/05.ptx: https://eae803db.tbil.pages.dev/preview/precalculus/instructor/FN5.html
source/precalculus/source/05-EL/03.ptx: https://eae803db.tbil.pages.dev/preview/precalculus/instructor/EL3.html
source/precalculus/source/05-EL/05.ptx: https://eae803db.tbil.pages.dev/preview/precalculus/instructor/EL5.html
source/precalculus/source/05-EL/06.ptx: https://eae803db.tbil.pages.dev/preview/precalculus/instructor/EL6.html


          Update source/precalculus/source/05-EL/05.ptx

7c16fa4

Co-authored-by: Abby Noble <85640990+AbbyANoble@users.noreply.github.com>

github-actions bot deployed to tbil (Preview)

December 17, 2024 22:20

View deployment

github-actions bot commented Dec 17, 2024

🚀 Preview available 🚀

https://53ca2b2f.tbil.pages.dev

source/precalculus/source/02-FN/05.ptx: https://53ca2b2f.tbil.pages.dev/preview/precalculus/instructor/FN5.html
source/precalculus/source/05-EL/03.ptx: https://53ca2b2f.tbil.pages.dev/preview/precalculus/instructor/EL3.html
source/precalculus/source/05-EL/05.ptx: https://53ca2b2f.tbil.pages.dev/preview/precalculus/instructor/EL5.html
source/precalculus/source/05-EL/06.ptx: https://53ca2b2f.tbil.pages.dev/preview/precalculus/instructor/EL6.html

Contributor

StevenClontz commented Dec 18, 2024

This pull request was not created correctly - it will merge into a feature branch rather than main 😭:

StevenClontz changed the base branch from Tonya-12-16-2024 to main

December 18, 2024 00:32

Contributor

StevenClontz commented Dec 18, 2024

I think this should work now. @AbbyANoble needs to leave an approving review before we can merge.

StevenClontz added the under-review label

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/03.ptx Outdated Show resolved Hide resolved

AbbyANoble added 2 commits

December 18, 2024 08:02


          Update source/precalculus/source/05-EL/03.ptx


          added <p> tag to remark

cfad711

github-actions bot deployed to tbil (Preview)

December 18, 2024 13:08

View deployment

github-actions bot commented Dec 18, 2024

🚀 Preview available 🚀

https://7d91034c.tbil.pages.dev

source/precalculus/source/05-EL/03.ptx: https://7d91034c.tbil.pages.dev/preview/precalculus/instructor/EL3.html
source/precalculus/source/05-EL/05.ptx: https://7d91034c.tbil.pages.dev/preview/precalculus/instructor/EL5.html
source/precalculus/source/05-EL/06.ptx: https://7d91034c.tbil.pages.dev/preview/precalculus/instructor/EL6.html

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/03.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/05-EL/05.ptx Outdated Show resolved Hide resolved

AbbyANoble reviewed

View reviewed changes

source/precalculus/source/02-FN/05.ptx Outdated

Contributor

AbbyANoble Dec 18, 2024

I'm not sure why this file is in this pull request? @siwelwerd or @StevenClontz?

Contributor

siwelwerd Dec 19, 2024

I think Tonya accidentally branched off of a branch, but I think it's fixed now

Contributor

AbbyANoble commented Dec 18, 2024 •

edited

Loading

Ok, I've reviewed it, but at this point I'm lost in the weeds of trying to see the big picture because things weren't compiling due to some missing paragraph tags in remarks. Can someone (@tdegeorge or @siwelwerd) look at what I've done and accept some of these commits? And then not close the issue so we can look it over again once things are compiling?

siwelwerd and others added 11 commits

December 19, 2024 15:21


          Update source/precalculus/source/05-EL/03.ptx

1301a0f

Co-authored-by: Abby Noble <85640990+AbbyANoble@users.noreply.github.com>


          Update source/precalculus/source/05-EL/05.ptx

483a4a6

Co-authored-by: Abby Noble <85640990+AbbyANoble@users.noreply.github.com>


          Update source/precalculus/source/05-EL/05.ptx

ac83ffc

Co-authored-by: Abby Noble <85640990+AbbyANoble@users.noreply.github.com>


          Update source/precalculus/source/05-EL/05.ptx

826fa73

Co-authored-by: Abby Noble <85640990+AbbyANoble@users.noreply.github.com>


          Update source/precalculus/source/05-EL/05.ptx

b74e514

Co-authored-by: Abby Noble <85640990+AbbyANoble@users.noreply.github.com>


          Update source/precalculus/source/05-EL/05.ptx

28ce3bf

Co-authored-by: Abby Noble <85640990+AbbyANoble@users.noreply.github.com>


          Update source/precalculus/source/05-EL/05.ptx

91ed363

Co-authored-by: Abby Noble <85640990+AbbyANoble@users.noreply.github.com>


          Update source/precalculus/source/05-EL/05.ptx

35c827d

Co-authored-by: Abby Noble <85640990+AbbyANoble@users.noreply.github.com>


          Update source/precalculus/source/05-EL/05.ptx

58906ec

Co-authored-by: Abby Noble <85640990+AbbyANoble@users.noreply.github.com>


          Update source/precalculus/source/05-EL/05.ptx

23c41db

Co-authored-by: Abby Noble <85640990+AbbyANoble@users.noreply.github.com>


          Discard changes to source/precalculus/source/02-FN/05.ptx

8c65973

github-actions bot deployed to tbil (Preview)

December 19, 2024 23:27

View deployment

github-actions bot commented Dec 19, 2024

🚀 Preview available 🚀

https://5c120d07.tbil.pages.dev

source/precalculus/source/05-EL/03.ptx: https://5c120d07.tbil.pages.dev/preview/precalculus/instructor/EL3.html
source/precalculus/source/05-EL/05.ptx: https://5c120d07.tbil.pages.dev/preview/precalculus/instructor/EL5.html
source/precalculus/source/05-EL/06.ptx: https://5c120d07.tbil.pages.dev/preview/precalculus/instructor/EL6.html

Contributor

siwelwerd commented Dec 19, 2024

I merged all of your commits @AbbyANoble , but I think it's still a little hard to follow since the remarks aren't showing up right. Maybe @StevenClontz can merge #514 into main to fix those, and then merge main into this so it's easier to see.


          Merge branch 'main' into Tonya-Issue-430

e881d7e

Contributor

StevenClontz commented Dec 20, 2024

Try that...


          fix mismatched p tag

1de4149

github-actions bot deployed to tbil (Preview)

December 20, 2024 02:35

View deployment

github-actions bot commented Dec 20, 2024

🚀 Preview available 🚀

https://8e81b869.tbil.pages.dev

source/precalculus/source/05-EL/03.ptx: https://8e81b869.tbil.pages.dev/preview/precalculus/instructor/EL3.html
source/precalculus/source/05-EL/05.ptx: https://8e81b869.tbil.pages.dev/preview/precalculus/instructor/EL5.html
source/precalculus/source/05-EL/06.ptx: https://8e81b869.tbil.pages.dev/preview/precalculus/instructor/EL6.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

precalculus under-review