-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroducing Quarkus Micro Tests #8606
Conversation
193b371
to
65da1e5
Compare
@NateBrady23 I'm waiting @Sanne to take a quick look: I'll change the naming of these new tests later or now depending the review |
Moving it in draft so I can change/improve the naming |
...rks/Java/quarkus/muggle/src/main/java/io/quarkus/benchmark/repository/FortuneRepository.java
Outdated
Show resolved
Hide resolved
LGTM - haven't benchmarked it but I guess we can see the nightly results ;) |
@Sanne i could bring in the enhanced update one for both pgclient and muggle, although I admit it complicate quite a bit the code (so you have the commit?) |
sure, why not |
28fc663
to
f25b06d
Compare
These are the whole number of test with the names which would appear on Techempower dashboard:
The last 2 are classified as "Raw" ORM, but |
why "JPA" ? We're not using the this API but the Hibernate one |
@Sanne fair point, just wanted a short name easier (in term of char-count, really) for users: for us the only name is the maven module/docker one (which report everything). if ORM works better is fine for me, is still short - if you have strong preference for using |
f25b06d
to
821f2ce
Compare
Guys, what is the point of having Quarkus Vertx when you only use dependency injection from Quarkus? To be fair, call it Vertx. |
@dstepanov |
The composite score will show just the raw Vertx performance labeled as Quarkus, not touching anything around Quarkus. What is the point of it? My personal opinion is that the code should be written as closely as you would recommend it to be in real life. |
Both scenarios are real world scenarios. |
The fact that everything goes under composite score regardless the filter(s) is a bug of techempower's UI, opened at #8621. As @geoand said all the cases are real worlds ones, in term of component choice, and given that we had no ORM reactive version in the past, it seems natural to me to have them back now. |
Given that Techempower allow to expose different flavours of the same flamework and Quarkus has a known capability of adapting itself, based on the required level of performance (see https://quarkus.io/blog/magic-control/) we're going to introduce (and re-introduce) 2 different types of Quarkus applications:
micro
classification andRaw
ORMfullstack
classification, butRaw
ORMThe plan is to have a nightly run on the Techempower CI and decide if remove/simplify again any of them, maybe renaming the existing one to better drive users into what each version actually do/what is meant for.