To do app - using zustand for state management #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Hi Sherry and Brian! Good job on completing this project. Your Zustand store looks well structured and you've met the requirements in general. I'd like to ask you to please clean up the code and to make sure you're VSC is set to 2 spaces for indentation. Also, remember that you don't need to import React.
Apart from that, keep up the good work!
Comment on lines
+16
to
+19
| <section className="task-count"> | ||
| <p>Total Tasks: {totalTasks}</p> | ||
| <p>Uncompleted Tasks: {uncompletedTasks}</p> | ||
| </section> |
There was a problem hiding this comment.
Maybe this could've been its own component?
| @@ -0,0 +1,40 @@ | |||
| // This component handles the input and allows adding new tasks. | |||
| import React, { useState } from "react"; | |||
There was a problem hiding this comment.
No need to import React
| import { useTodoStore } from "../store/todoStore"; | ||
|
|
||
| export const TaskInput = () => { | ||
| const [inputValue, setInputValue] = useState(""); |
There was a problem hiding this comment.
2 spaces indentation is enough
Comment on lines
+22
to
+28
| <input | ||
| type="text" | ||
| value={inputValue} | ||
| onChange={(e) => setInputValue(e.target.value)} | ||
| placeholder="Add a new task" | ||
| aria-label="Task input" // Accessibility for screen readers. | ||
| /> |
There was a problem hiding this comment.
Don't forget labels for form elements!!
Comment on lines
+36
to
+40
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
One empty line is enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://taskmastertodoapp.netlify.app/
Collaborators
Collabed with: https://github.com/smily342