Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do: Nella #37

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

To-do: Nella #37

wants to merge 8 commits into from

Conversation

nella-x
Copy link

@nella-x nella-x commented Nov 24, 2024

Netlify link

https://nella-todo.netlify.app/

Collaborators

Add any collaborators here.

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-structured Zustand store and lovely to see that you're utilizing Tailwind as well as local storage. Next time you might want to look up the persist middleware for Zustand. It was not in the material but Zustand's official documentation should suffice.

Why do you have one todoStore and one taskStore? Remove the code you're not using. On the same topic, be consistent with naming - i.e. AddTask.jsx, Task.jsx, TaskList.jsx.

return (
<form onSubmit={handleSubmit} className="relative w-full flex flex-col gap-2">
<div className="relative w-full">
<input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget labels!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants