feat(Sheet): IOS-10691 add separators to the sheet informative list

* IOS-10691 add separators to the sheet informative list and adjusted margins * IOS-10691 implement method to add rows with optional separators to the stack view * Run swiftformat * Record screenshots automatically launched from GH action --------- Co-authored-by: L-Trujillo26 <L-Trujillo26@users.noreply.github.com>
Telefonica · Dec 4, 2024 · d093f1f · d093f1f
1 parent 7f3620b
commit d093f1f
Show file tree

Hide file tree

Showing 82 changed files with 29 additions and 13 deletions.
diff --git a/Sources/Mistica/Components/Sheet/View/Fragments/List/ListFragmentView.swift b/Sources/Mistica/Components/Sheet/View/Fragments/List/ListFragmentView.swift
@@ -96,9 +96,10 @@ private extension ListFragmentView {
     }
 
     func fillListWithInformativeItems(_ items: [InformativeItem]) {
-        for item in items {
+        for (index, item) in items.enumerated() {
             let rowView = InformativeRow(item: item)
-            stackView.addArrangedSubview(rowView)
+            let isLastItem = index == items.count - 1
+            addRow(rowView, withSeparator: !isLastItem)
         }
     }
 
@@ -129,16 +130,7 @@ private extension ListFragmentView {
         self.stackView.addArrangedSubview(stackView)
     }
 
-    func button(at index: Int, for action: ActionItem) -> Button {
-        let button = Button(
-            style: action.style,
-            title: action.title,
-            rightImage: action.rightImage
-        )
-        button.tag = index
-        button.addTarget(self, action: #selector(didTap(action:)), for: .touchUpInside)
-        return button
-    }
+    // MARK: User Interaction
 
     @objc private func didTouchItem(_ sender: UILongPressGestureRecognizer) {
         guard let touchable = sender.view as? Touchable else { return }
@@ -207,3 +199,27 @@ extension ListFragmentView: UIGestureRecognizerDelegate {
         true
     }
 }
+
+// MARK: Utilities
+
+private extension ListFragmentView {
+    func addRow(_ row: UIView, withSeparator: Bool = false) {
+        stackView.addArrangedSubview(row)
+
+        if withSeparator {
+            let separator = SeparatorView(axis: .horizontal)
+            stackView.addArrangedSubview(separator)
+        }
+    }
+
+    func button(at index: Int, for action: ActionItem) -> Button {
+        let button = Button(
+            style: action.style,
+            title: action.title,
+            rightImage: action.rightImage
+        )
+        button.tag = index
+        button.addTarget(self, action: #selector(didTap(action:)), for: .touchUpInside)
+        return button
+    }
+}
diff --git a/Sources/Mistica/Components/Sheet/View/Fragments/List/Rows/InformativeRow.swift b/Sources/Mistica/Components/Sheet/View/Fragments/List/Rows/InformativeRow.swift
@@ -49,7 +49,7 @@ class InformativeRow: UIView {
         stackView.alignment = .leading
         stackView.axis = .vertical
         stackView.isLayoutMarginsRelativeArrangement = true
-        stackView.layoutMargins = .init(top: 16, left: 0, bottom: 0, right: 0)
+        stackView.layoutMargins = .init(top: 16, left: 0, bottom: 16, right: 0)
         return stackView
     }()
 

diff --git a/...heetTests/testInformativeWithDescriptionAndRegularIcon.with-blau-dark-style.png b/...heetTests/testInformativeWithDescriptionAndRegularIcon.with-blau-dark-style.png
diff --git a/...s__/SheetTests/testInformativeWithDescriptionAndRegularIcon.with-blau-style.png b/...s__/SheetTests/testInformativeWithDescriptionAndRegularIcon.with-blau-style.png
diff --git a/...Tests/testInformativeWithDescriptionAndRegularIcon.with-movistar-dark-style.png b/...Tests/testInformativeWithDescriptionAndRegularIcon.with-movistar-dark-style.png
diff --git a/...SheetTests/testInformativeWithDescriptionAndRegularIcon.with-movistar-style.png b/...SheetTests/testInformativeWithDescriptionAndRegularIcon.with-movistar-style.png
diff --git a/.../SheetTests/testInformativeWithDescriptionAndRegularIcon.with-o2-dark-style.png b/.../SheetTests/testInformativeWithDescriptionAndRegularIcon.with-o2-dark-style.png
diff --git a/...ots__/SheetTests/testInformativeWithDescriptionAndRegularIcon.with-o2-style.png b/...ots__/SheetTests/testInformativeWithDescriptionAndRegularIcon.with-o2-style.png
diff --git a/...eetTests/testInformativeWithDescriptionAndRegularIcon.with-o2New-dark-style.png b/...eetTests/testInformativeWithDescriptionAndRegularIcon.with-o2New-dark-style.png
diff --git a/...__/SheetTests/testInformativeWithDescriptionAndRegularIcon.with-o2New-style.png b/...__/SheetTests/testInformativeWithDescriptionAndRegularIcon.with-o2New-style.png
diff --git a/...sts/testInformativeWithDescriptionAndRegularIcon.with-telefonica-dark-style.png b/...sts/testInformativeWithDescriptionAndRegularIcon.with-telefonica-dark-style.png
diff --git a/...eetTests/testInformativeWithDescriptionAndRegularIcon.with-telefonica-style.png b/...eetTests/testInformativeWithDescriptionAndRegularIcon.with-telefonica-style.png
diff --git a/.../SheetTests/testInformativeWithDescriptionAndRegularIcon.with-tu-dark-style.png b/.../SheetTests/testInformativeWithDescriptionAndRegularIcon.with-tu-dark-style.png
diff --git a/...ots__/SheetTests/testInformativeWithDescriptionAndRegularIcon.with-tu-style.png b/...ots__/SheetTests/testInformativeWithDescriptionAndRegularIcon.with-tu-style.png
diff --git a/...heetTests/testInformativeWithDescriptionAndRegularIcon.with-vivo-dark-style.png b/...heetTests/testInformativeWithDescriptionAndRegularIcon.with-vivo-dark-style.png
diff --git a/...s__/SheetTests/testInformativeWithDescriptionAndRegularIcon.with-vivo-style.png b/...s__/SheetTests/testInformativeWithDescriptionAndRegularIcon.with-vivo-style.png
diff --git a/...tTests/testInformativeWithDescriptionAndRegularIcon.with-vivoNew-dark-style.png b/...tTests/testInformativeWithDescriptionAndRegularIcon.with-vivoNew-dark-style.png
diff --git a/.../SheetTests/testInformativeWithDescriptionAndRegularIcon.with-vivoNew-style.png b/.../SheetTests/testInformativeWithDescriptionAndRegularIcon.with-vivoNew-style.png
diff --git a/.../SheetTests/testInformativeWithDescriptionAndSmallIcon.with-blau-dark-style.png b/.../SheetTests/testInformativeWithDescriptionAndSmallIcon.with-blau-dark-style.png
diff --git a/...ots__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-blau-style.png b/...ots__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-blau-style.png
diff --git a/...etTests/testInformativeWithDescriptionAndSmallIcon.with-movistar-dark-style.png b/...etTests/testInformativeWithDescriptionAndSmallIcon.with-movistar-dark-style.png
diff --git a/..._/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-movistar-style.png b/..._/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-movistar-style.png
diff --git a/...__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-o2-dark-style.png b/...__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-o2-dark-style.png
diff --git a/...shots__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-o2-style.png b/...shots__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-o2-style.png
diff --git a/...SheetTests/testInformativeWithDescriptionAndSmallIcon.with-o2New-dark-style.png b/...SheetTests/testInformativeWithDescriptionAndSmallIcon.with-o2New-dark-style.png
diff --git a/...ts__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-o2New-style.png b/...ts__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-o2New-style.png
diff --git a/...Tests/testInformativeWithDescriptionAndSmallIcon.with-telefonica-dark-style.png b/...Tests/testInformativeWithDescriptionAndSmallIcon.with-telefonica-dark-style.png
diff --git a/...SheetTests/testInformativeWithDescriptionAndSmallIcon.with-telefonica-style.png b/...SheetTests/testInformativeWithDescriptionAndSmallIcon.with-telefonica-style.png
diff --git a/...__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-tu-dark-style.png b/...__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-tu-dark-style.png
diff --git a/...shots__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-tu-style.png b/...shots__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-tu-style.png
diff --git a/.../SheetTests/testInformativeWithDescriptionAndSmallIcon.with-vivo-dark-style.png b/.../SheetTests/testInformativeWithDescriptionAndSmallIcon.with-vivo-dark-style.png
diff --git a/...ots__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-vivo-style.png b/...ots__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-vivo-style.png
diff --git a/...eetTests/testInformativeWithDescriptionAndSmallIcon.with-vivoNew-dark-style.png b/...eetTests/testInformativeWithDescriptionAndSmallIcon.with-vivoNew-dark-style.png
diff --git a/...__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-vivoNew-style.png b/...__/SheetTests/testInformativeWithDescriptionAndSmallIcon.with-vivoNew-style.png
diff --git a/...etTests/testInformativeWithoutDescriptionAndBulletIcon.with-blau-dark-style.png b/...etTests/testInformativeWithoutDescriptionAndBulletIcon.with-blau-dark-style.png
diff --git a/..._/SheetTests/testInformativeWithoutDescriptionAndBulletIcon.with-blau-style.png b/..._/SheetTests/testInformativeWithoutDescriptionAndBulletIcon.with-blau-style.png
diff --git a/...sts/testInformativeWithoutDescriptionAndBulletIcon.with-movistar-dark-style.png b/...sts/testInformativeWithoutDescriptionAndBulletIcon.with-movistar-dark-style.png
diff --git a/...eetTests/testInformativeWithoutDescriptionAndBulletIcon.with-movistar-style.png b/...eetTests/testInformativeWithoutDescriptionAndBulletIcon.with-movistar-style.png
diff --git a/...heetTests/testInformativeWithoutDescriptionAndBulletIcon.with-o2-dark-style.png b/...heetTests/testInformativeWithoutDescriptionAndBulletIcon.with-o2-dark-style.png
diff --git a/...s__/SheetTests/testInformativeWithoutDescriptionAndBulletIcon.with-o2-style.png b/...s__/SheetTests/testInformativeWithoutDescriptionAndBulletIcon.with-o2-style.png
diff --git a/...tTests/testInformativeWithoutDescriptionAndBulletIcon.with-o2New-dark-style.png b/...tTests/testInformativeWithoutDescriptionAndBulletIcon.with-o2New-dark-style.png
diff --git a/.../SheetTests/testInformativeWithoutDescriptionAndBulletIcon.with-o2New-style.png b/.../SheetTests/testInformativeWithoutDescriptionAndBulletIcon.with-o2New-style.png
diff --git a/...s/testInformativeWithoutDescriptionAndBulletIcon.with-telefonica-dark-style.png b/...s/testInformativeWithoutDescriptionAndBulletIcon.with-telefonica-dark-style.png
diff --git a/...tTests/testInformativeWithoutDescriptionAndBulletIcon.with-telefonica-style.png b/...tTests/testInformativeWithoutDescriptionAndBulletIcon.with-telefonica-style.png
diff --git a/...heetTests/testInformativeWithoutDescriptionAndBulletIcon.with-tu-dark-style.png b/...heetTests/testInformativeWithoutDescriptionAndBulletIcon.with-tu-dark-style.png
diff --git a/...s__/SheetTests/testInformativeWithoutDescriptionAndBulletIcon.with-tu-style.png b/...s__/SheetTests/testInformativeWithoutDescriptionAndBulletIcon.with-tu-style.png
diff --git a/...etTests/testInformativeWithoutDescriptionAndBulletIcon.with-vivo-dark-style.png b/...etTests/testInformativeWithoutDescriptionAndBulletIcon.with-vivo-dark-style.png
diff --git a/..._/SheetTests/testInformativeWithoutDescriptionAndBulletIcon.with-vivo-style.png b/..._/SheetTests/testInformativeWithoutDescriptionAndBulletIcon.with-vivo-style.png
diff --git a/...ests/testInformativeWithoutDescriptionAndBulletIcon.with-vivoNew-dark-style.png b/...ests/testInformativeWithoutDescriptionAndBulletIcon.with-vivoNew-dark-style.png
diff --git a/...heetTests/testInformativeWithoutDescriptionAndBulletIcon.with-vivoNew-style.png b/...heetTests/testInformativeWithoutDescriptionAndBulletIcon.with-vivoNew-style.png
diff --git a/...tTests/testInformativeWithoutDescriptionAndRegularIcon.with-blau-dark-style.png b/...tTests/testInformativeWithoutDescriptionAndRegularIcon.with-blau-dark-style.png
diff --git a/.../SheetTests/testInformativeWithoutDescriptionAndRegularIcon.with-blau-style.png b/.../SheetTests/testInformativeWithoutDescriptionAndRegularIcon.with-blau-style.png
diff --git a/...ts/testInformativeWithoutDescriptionAndRegularIcon.with-movistar-dark-style.png b/...ts/testInformativeWithoutDescriptionAndRegularIcon.with-movistar-dark-style.png
diff --git a/...etTests/testInformativeWithoutDescriptionAndRegularIcon.with-movistar-style.png b/...etTests/testInformativeWithoutDescriptionAndRegularIcon.with-movistar-style.png
diff --git a/...eetTests/testInformativeWithoutDescriptionAndRegularIcon.with-o2-dark-style.png b/...eetTests/testInformativeWithoutDescriptionAndRegularIcon.with-o2-dark-style.png
diff --git a/...__/SheetTests/testInformativeWithoutDescriptionAndRegularIcon.with-o2-style.png b/...__/SheetTests/testInformativeWithoutDescriptionAndRegularIcon.with-o2-style.png
diff --git a/...Tests/testInformativeWithoutDescriptionAndRegularIcon.with-o2New-dark-style.png b/...Tests/testInformativeWithoutDescriptionAndRegularIcon.with-o2New-dark-style.png
diff --git a/...SheetTests/testInformativeWithoutDescriptionAndRegularIcon.with-o2New-style.png b/...SheetTests/testInformativeWithoutDescriptionAndRegularIcon.with-o2New-style.png
diff --git a/.../testInformativeWithoutDescriptionAndRegularIcon.with-telefonica-dark-style.png b/.../testInformativeWithoutDescriptionAndRegularIcon.with-telefonica-dark-style.png
diff --git a/...Tests/testInformativeWithoutDescriptionAndRegularIcon.with-telefonica-style.png b/...Tests/testInformativeWithoutDescriptionAndRegularIcon.with-telefonica-style.png
diff --git a/...eetTests/testInformativeWithoutDescriptionAndRegularIcon.with-tu-dark-style.png b/...eetTests/testInformativeWithoutDescriptionAndRegularIcon.with-tu-dark-style.png
diff --git a/...__/SheetTests/testInformativeWithoutDescriptionAndRegularIcon.with-tu-style.png b/...__/SheetTests/testInformativeWithoutDescriptionAndRegularIcon.with-tu-style.png
diff --git a/...tTests/testInformativeWithoutDescriptionAndRegularIcon.with-vivo-dark-style.png b/...tTests/testInformativeWithoutDescriptionAndRegularIcon.with-vivo-dark-style.png
diff --git a/.../SheetTests/testInformativeWithoutDescriptionAndRegularIcon.with-vivo-style.png b/.../SheetTests/testInformativeWithoutDescriptionAndRegularIcon.with-vivo-style.png
diff --git a/...sts/testInformativeWithoutDescriptionAndRegularIcon.with-vivoNew-dark-style.png b/...sts/testInformativeWithoutDescriptionAndRegularIcon.with-vivoNew-dark-style.png
diff --git a/...eetTests/testInformativeWithoutDescriptionAndRegularIcon.with-vivoNew-style.png b/...eetTests/testInformativeWithoutDescriptionAndRegularIcon.with-vivoNew-style.png
diff --git a/...eetTests/testInformativeWithoutDescriptionAndSmallIcon.with-blau-dark-style.png b/...eetTests/testInformativeWithoutDescriptionAndSmallIcon.with-blau-dark-style.png
diff --git a/...__/SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-blau-style.png b/...__/SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-blau-style.png
diff --git a/...ests/testInformativeWithoutDescriptionAndSmallIcon.with-movistar-dark-style.png b/...ests/testInformativeWithoutDescriptionAndSmallIcon.with-movistar-dark-style.png
diff --git a/...heetTests/testInformativeWithoutDescriptionAndSmallIcon.with-movistar-style.png b/...heetTests/testInformativeWithoutDescriptionAndSmallIcon.with-movistar-style.png
diff --git a/...SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-o2-dark-style.png b/...SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-o2-dark-style.png
diff --git a/...ts__/SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-o2-style.png b/...ts__/SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-o2-style.png
diff --git a/...etTests/testInformativeWithoutDescriptionAndSmallIcon.with-o2New-dark-style.png b/...etTests/testInformativeWithoutDescriptionAndSmallIcon.with-o2New-dark-style.png
diff --git a/..._/SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-o2New-style.png b/..._/SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-o2New-style.png
diff --git a/...ts/testInformativeWithoutDescriptionAndSmallIcon.with-telefonica-dark-style.png b/...ts/testInformativeWithoutDescriptionAndSmallIcon.with-telefonica-dark-style.png
diff --git a/...etTests/testInformativeWithoutDescriptionAndSmallIcon.with-telefonica-style.png b/...etTests/testInformativeWithoutDescriptionAndSmallIcon.with-telefonica-style.png
diff --git a/...SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-tu-dark-style.png b/...SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-tu-dark-style.png
diff --git a/...ts__/SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-tu-style.png b/...ts__/SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-tu-style.png
diff --git a/...eetTests/testInformativeWithoutDescriptionAndSmallIcon.with-vivo-dark-style.png b/...eetTests/testInformativeWithoutDescriptionAndSmallIcon.with-vivo-dark-style.png
diff --git a/...__/SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-vivo-style.png b/...__/SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-vivo-style.png
diff --git a/...Tests/testInformativeWithoutDescriptionAndSmallIcon.with-vivoNew-dark-style.png b/...Tests/testInformativeWithoutDescriptionAndSmallIcon.with-vivoNew-dark-style.png
diff --git a/...SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-vivoNew-style.png b/...SheetTests/testInformativeWithoutDescriptionAndSmallIcon.with-vivoNew-style.png