Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/angular 18 upgrade #2283

Merged
merged 26 commits into from
Jan 10, 2025
Merged

Feat/angular 18 upgrade #2283

merged 26 commits into from
Jan 10, 2025

Conversation

bsahitya
Copy link
Collaborator

Description

Upgrade Covalent to Angular 18

What's included?

  • Angular upgrade to version 18
  • Fix some linting errors

Test Steps

  • nx run docs-app:serve
  • then verify all components function correctly
  • Then run npm run storybook and verify all web components function correctly

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

angular-18-storybook
angular-18

@owilliams320 owilliams320 temporarily deployed to covalent-pip-feat-angul-smt478 November 27, 2024 19:49 Inactive
@owilliams320 owilliams320 temporarily deployed to covalent-pip-feat-angul-smt478 December 3, 2024 15:46 Inactive
@owilliams320 owilliams320 temporarily deployed to covalent-pip-feat-angul-smt478 December 3, 2024 15:55 Inactive
@owilliams320 owilliams320 temporarily deployed to covalent-pip-feat-angul-smt478 December 3, 2024 16:01 Inactive
@owilliams320 owilliams320 temporarily deployed to covalent-pip-feat-angul-smt478 December 3, 2024 16:12 Inactive
owilliams320
owilliams320 previously approved these changes Dec 16, 2024
@owilliams320 owilliams320 temporarily deployed to covalent-pip-feat-angul-dyskwm January 9, 2025 19:26 Inactive
@owilliams320 owilliams320 temporarily deployed to covalent-pip-feat-angul-dyskwm January 9, 2025 21:52 Inactive
@owilliams320 owilliams320 temporarily deployed to covalent-pip-feat-angul-dyskwm January 9, 2025 22:06 Inactive
Copy link
Collaborator

@owilliams320 owilliams320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you @bsahitya for these contributions!! 👩🏽‍🎤

@owilliams320 owilliams320 merged commit 90fe11c into main Jan 10, 2025
7 checks passed
@owilliams320 owilliams320 deleted the feat/angular-18-upgrade branch January 10, 2025 20:04
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants