-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/angular 18 upgrade #2283
Merged
Merged
Feat/angular 18 upgrade #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Upgrade covalent to Angular 18
owilliams320
temporarily deployed
to
covalent-pip-feat-angul-smt478
November 27, 2024 19:49
Inactive
owilliams320
previously approved these changes
Dec 16, 2024
owilliams320
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you @bsahitya for these contributions!! 👩🏽🎤
🎉 This PR is included in version 9.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade Covalent to Angular 18
What's included?
Test Steps
nx run docs-app:serve
npm run storybook
and verify all web components function correctlyGeneral Tests for Every PR
npm run start
still works.npm run lint
passes.npm run stylelint
passes.npm test
passes and code coverage is not lower.npm run build
still works.Screenshots or link to StackBlitz/Plunker