finished tic tac toe #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,31 @@ | |||
| .symbol { | |||
There was a problem hiding this comment.
Each of your styles aligns to a classname referenced in your app. 💯
| const App = () => { | ||
| return <div>A tic-tac-toe game</div>; | ||
| return ( |
There was a problem hiding this comment.
Each of this app's components renders a logical child component. Using modules generally results in code that is easier to read and maintain. 💯
Comment on lines
+52
to
+65
| <Squares click={() => clickHandler(0)} value={boardState[0]}/> | ||
| <Squares click={() => clickHandler(1)} value={boardState[1]}/> | ||
| <Squares click={() => clickHandler(2)} value={boardState[2]}/> | ||
| </div> | ||
| <div className="rows"> | ||
| <Squares click={() => clickHandler(3)} value={boardState[3]}/> | ||
| <Squares click={() => clickHandler(4)} value={boardState[4]}/> | ||
| <Squares click={() => clickHandler(5)} value={boardState[5]}/> | ||
| </div> | ||
| <div className="rows"> | ||
| <Squares click={() => clickHandler(6)} value={boardState[6]}/> | ||
| <Squares click={() => clickHandler(7)} value={boardState[7]}/> | ||
| <Squares click={() => clickHandler(8)} value={boardState[8]}/> | ||
| </div> |
There was a problem hiding this comment.
Having access to boardState gives a perfect opportunity to use .map() to render<Squares/> rather than hardcoding each instance.
| @@ -0,0 +1,5 @@ | |||
| function Squares(props) { | |||
| return ( | |||
| <div className="symbol" onClick={props.click}>{props.value}</div> | |||
There was a problem hiding this comment.
This is just a matter of preference: when using multiple props, the destructuring assignment can be used to help reduce code repetition. This is especially helpful in components with an increased number of props.
Suggested change
| <div className="symbol" onClick={props.click}>{props.value}</div> | |
| const {click, value} = props; | |
| return ( | |
| <div className="symbol" onClick={click}>{value}</div> | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.