psm: add check for bterms option #6584
Open
+83
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
reviewed
Jan 23, 2025
| @@ -69,6 +70,7 @@ check_power_grid | |||
| | `-net` | Name of the net to analyze. Must be a power or ground net name. | | |||
| | `-floorplanning` | Ignore non-fixed instances in the power grid, this is useful during floorplanning analysis when instances may not be properly placed. | | |||
| | `-error_file` | File to write power grid errors to. | | |||
| | `-require_terminals` | If specified, this will check of there are terminals on the net. | | |||
There was a problem hiding this comment.
Do you think this should be off by default or on?
There was a problem hiding this comment.
I would suggest on by default, but that might have some short term implications on CI tests that run this command
There was a problem hiding this comment.
Then let's flip the option to on by default with an off option. We might as well sort out the CI now as in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
check_power_grid