-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring the files to be in correctly nested packages #6120
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6120 +/- ##
============================================
+ Coverage 73.78% 73.79% +0.01%
Complexity 5119 5119
============================================
Files 658 658
Lines 17632 17632
Branches 3391 3391
============================================
+ Hits 13010 13012 +2
+ Misses 4118 4117 -1
+ Partials 504 503 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Please check why build and linter fail, you probably need to fix formatting to fix them |
Or try updating with the base branch |
Im not sure what fails in the build. locally is fine. It says some PMD check failed not sure how to resolve |
Regarding PMD (cf. logs):
So it should be enough to remove the Regarding clang-format (cf. logs):
i.e. move the |
@varada610: as an addition to: After you will fix the PMD issues, please remove this line: Line 58 in a9633c0
|
src/test/java/com/thealgorithms/matrix/InverseOfMatrixTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
clang-format -i --style=file path/to/your/file.java