Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algorithm : add binary convert in Maths #18

Closed
wants to merge 23 commits into from
Closed

algorithm : add binary convert in Maths #18

wants to merge 23 commits into from

Conversation

Owais28
Copy link
Contributor

@Owais28 Owais28 commented Sep 26, 2022

Describe Changes :

Owais28 and others added 23 commits September 24, 2022 21:59
>
> ### Describe your change:
> * [x]  Add an algorithm?
> * [ ]  Fix a bug or typo in an existing algorithm?
> * [ ]  Documentation change?
>
> ### Checklist:
> * [x]  I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Javascript/blob/master/CONTRIBUTING.md).
> * [x]  This pull request is all my own work -- I have not plagiarized.
> * [x]  I know that pull requests will not be merged if they fail the automated tests.
> * [x]  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
> * [x]  All new JavaScript files are placed inside an existing directory.
> * [x]  All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
>   **Example:**`UserProfile.js` is allowed but `userprofile.js`,`Userprofile.js`,`user-Profile.js`,`userProfile.js` are not
> * [x]  All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
> * [x]  If this pull request resolves one or more open issues then the commit message contains `Fixes: #{$ISSUE_NO}`.
- removed extra unused configurations
@Owais28 Owais28 changed the title algorithm : add binary convert in Maths algorithm : add binary convert in Maths #12 Sep 26, 2022
@Owais28 Owais28 changed the title algorithm : add binary convert in Maths #12 algorithm : add binary convert in Maths Sep 26, 2022
@Panquesito7 Panquesito7 added the enhancement New feature or request label Sep 26, 2022
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are quickselect & abs doing here?

@Owais28
Copy link
Contributor Author

Owais28 commented Sep 27, 2022

What are quickselect & abs doing here?
Let me reset everything.

@Owais28 Owais28 closed this Sep 27, 2022
@appgurueu
Copy link
Contributor

Please also wait for #5 and first open a tooling PR rather than adding your tooling in your first algo PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants