SA-3610 GHA Migration #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loud/jcapi-powershell into SA-3610_GHA_Workflow_Migrations
jworkmanjc
temporarily deployed
to
PublishToPSGallery
GitHub Actions
Inactive
jworkmanjc
temporarily deployed
to
PublishToPSGallery
GitHub Actions
Inactive
jworkmanjc
temporarily deployed
to
PublishToPSGallery
GitHub Actions
Inactive
jworkmanjc
temporarily deployed
to
PublishToPSGallery
GitHub Actions
Inactive
jworkmanjc
commented
Nov 14, 2023
| @@ -291,7 +290,7 @@ ForEach ($SDK In $SDKName) | |||
| # Remove auto generated .gitignore files | |||
| If ($ModifyGitIgnore) | |||
| { | |||
| $GitIgnoreFiles = Get-ChildItem -Path:($OutputFullPath) -Recurse -File | Where-Object { $_.Extension -eq '.gitignore' } | |||
| $GitIgnoreFiles = Get-ChildItem -Path:($OutputFullPath) -Recurse -File -Hidden | Where-Object { $_.Extension -eq '.gitignore' } | |||
There was a problem hiding this comment.
required to update .gitignore files
gweinjc
previously approved these changes
Nov 14, 2023
kmaranionjc
previously approved these changes
Nov 14, 2023
kmaranionjc
approved these changes
Nov 14, 2023
gweinjc
approved these changes
Nov 15, 2023
jworkmanjc
temporarily deployed
to
PublishToPSGallery
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What does this solve?
Replace CircleCI with GHA. Release
Start-JCSdkCommandfunction within the V1 module.Is there anything particularly tricky?
Not much has changed, a few things have been removed in favor of faster tests.
How should this be tested?
Team to discuss and show how module release steps have been tested.
Screenshots