[PP-2055] Use Ensure that local analytics events are committed to the… #2250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… database by running the event collection within a transaction.
Also use one transaction per event collected to minimize database lock durations.
Before this update, we were using task.session() which does not automatically commit when used in a
with
block. While the S3 analytics provider doesn't make any database updates, the Local Analytics Provider does. As a result, the updates to the local analytics provider which is backed by the database were not being committed.Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-2055
How Has This Been Tested?
Checklist