Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure collection subscription setting visibility via environment. (PP-2064) #2265

Draft
wants to merge 1 commit into
base: feature/collection-active-date-configuration
Choose a base branch
from

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Jan 23, 2025

Description

Control the visibility of the collection subscription configuration settings via an environment variable (PALACE_ADMINUI_HIDE_SUBSCRIPTION_CONFIG).

TODO: Still needs some tests.

Motivation and Context

Prevent accidental configuration of collection subscriptions for some CM instances while that feature is being built out.

[Jira PP-2064]

How Has This Been Tested?

TODO: Still need to add some tests.

Checklist

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (83e1fcb) to head (76bd8a3).

Additional details and impacted files
@@                              Coverage Diff                              @@
##           feature/collection-active-date-configuration    #2265   +/-   ##
=============================================================================
  Coverage                                         91.11%   91.12%           
=============================================================================
  Files                                               363      363           
  Lines                                             41303    41313   +10     
  Branches                                           8843     8845    +2     
=============================================================================
+ Hits                                              37635    37645   +10     
  Misses                                             2406     2406           
  Partials                                           1262     1262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant