Implement Github Actions #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabijaczleweli
requested changes
Dec 28, 2021
There was a problem hiding this comment.
Looks great! Cf. mostly nomenclatural notes below.
For reference, here's the set of jobs this generated. (I don't seem to be able to let'er rip in this repo, I guess it needs to have Anything at first.)
nabijaczleweli
approved these changes
Dec 28, 2021
There was a problem hiding this comment.
Looks good to me. https://github.com/jameskr97/infoware/actions/runs/1632159485 seems to've completed without issues, too.
nabijaczleweli
pushed a commit
that referenced
this pull request
Dec 28, 2021
|
Applied as 88b1ac1, thanks! |
nabijaczleweli
pushed a commit
that referenced
this pull request
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI for infoware 🛠️
My intention is to build on all three platforms as I mentioned in #47. I noticed that someone had already made PR #57 before I had the chance to make this PR, thought I wanted to still share what I created, and let the maintainers choose if they would like to merge.
The main differences, is that I use one
.ymlfile for all three operating systems. In my experience, it simplifies seeing which build failed and for which commit, verses when they are in two separate files, and you have to look at two separate separate GHA detail pages.The only idea I pulled from #57 is adding the build status badges to the
README.md. I did switch to use HTML only for the top portion with theinfowareheader, andaandimgtags for the badges. In my opinion it looks cleaner that having all the badge+header info on a single line, though if this is not desired, I'm happy to revert the commit. (Regaurdless of switching or not, until a PR is merged, and an action CI is run on ThePhD's page, the badge on theREADME.mdwon't properly show a badge)I was able to use ninja all three OS's. It's was able to notably cut down on my compile times for my other projects, so it's a go-to for most projects.
I was unsure what the desired CMake variable settings were, so I went with:
INFOWARE_USE_OPENCL=ON(Except Windows)INFOWARE_EXAMPLES=ONINFOWARE_TESTS=ONPlease let me know if I should make any changes!