Explicitly add the dwell time duration #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References #48
Changes
Notes for Reviewers
The lack of duration fails the validation:
https://github.com/TheThingsNetwork/lorawan-stack/blob/9d58a370c158a60072ed841370a5e7a97b67f419/pkg/frequencyplans/frequencyplans.go#L429-L431
During my tests I only verified that disabling works, which was not enough.
I will add CI checks as part of #38 which will catch these issues in the future.
Checklist