Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google's maven repository to avoid to depend on JCenter dependency for Android #2552

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

iagormoraes
Copy link
Contributor

@iagormoraes iagormoraes commented Dec 9, 2021

Description

This changes add a stable build for android without JCenter repository as bintray will shut down in Feb 1st 2022.

@iagormoraes iagormoraes changed the title Add google's maven repository JCenter for Android Add google's maven repository to JCenter dependency for Android Dec 9, 2021
@iagormoraes iagormoraes changed the title Add google's maven repository to JCenter dependency for Android Add google's maven repository to avoid to depend on JCenter dependency for Android Jan 3, 2022
@carl0shd
Copy link

+1, we need this change merged before jcenter fully shutdown

@jasonprado
Copy link

jcenter is down today so builds using this package are currently broken.

@husainkantawalaFS
Copy link

Any solutions, this repo is broken currently ?

@jgalianoz
Copy link

Merge please 🙏🏼

@Techie-Pi
Copy link

@iagormoraes Could you publish an npm package with your modification to be able to use your fix?

@Techie-Pi
Copy link

Any solutions, this repo is broken currently ?

You could do npm install github:iagormoraes/react-native-video instead of npm install react-native-video, although I haven't tried yet

@Techie-Pi
Copy link

According to #2343, @redefinered and @zchwyng are collaborators on this repository, they may able to help merging this pull request

@HanYoung-uwu
Copy link

as a workaround:

try changing your dependency in package.json to this:
"react-native-video": "https://github.com/MatrixFrog/react-native-video#4f6dad990d17ce42894df993780b5386a9c11b85",

and re-run npm install.

from here

@isair isair merged commit 63f12ea into TheWidlarzGroup:master Jan 19, 2022
@jherencia
Copy link

This PR was merged yesterday, but no release has been generated.

63f12ea

It seems that the CHANGELOG points to 5.2.1, but no tag or update to package.json has been done.

@joy-betterhalf
Copy link

Hey, @iagormoraes Great job on this PR.

@isair @zchwyng When you guys are planning a new release?

@altanaka
Copy link

altanaka commented Feb 1, 2022

Not sure why they haven't published yet, but here is a direct fork with a publish in the meantime:
https://github.com/altanaka/react-native-video

you will have to change your react-native-video dependency to
"react-native-video":"https://github.com/altanaka/react-native-video"

remove the old module and npm i

hopefully they make an official release soon

@DominicHulsey
Copy link

Not sure why they haven't published yet, but here is a direct fork with a publish in the meantime: https://github.com/altanaka/react-native-video

you will have to change your react-native-video dependency to "react-native-video":"https://github.com/altanaka/react-native-video"

remove the old module and npm i

hopefully they make an official release soon

This works, hopefully they publish soon

@yasircodingcrafts
Copy link

github:iagormoraes/react-native-video

I tried this module but still getting the same error on my app center build.

Screenshot 2022-03-09 at 2 44 34 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.