[MIG] trp_external_user #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NL66278
reviewed
Aug 12, 2021
trp_external_user/__manifest__.py
Outdated
| "version": "13.0.1.0.0", | ||
| "author": "Therp BV, Sunflower IT", | ||
| "category": 'External users', | ||
| 'website': 'http://therp.nl', |
NL66278
reviewed
Aug 12, 2021
trp_external_user/__manifest__.py
Outdated
| "author": "Therp BV, Sunflower IT", | ||
| "category": 'External users', | ||
| 'website': 'http://therp.nl', | ||
| 'depends': [ |
There was a problem hiding this comment.
Inconsistent quotation. Just black all of the code in the module. Best to install pre-commit to enforce this. The needed configuration is already in the 13.0 branch. See: https://odoo-community.org/blog/the-oca-blog-1/post/black-isort-pre-commit-97
NL66278
reviewed
Aug 12, 2021
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <odoo> | |||
| <record model="ir.module.category" id="module_category_external_users"> | |||
There was a problem hiding this comment.
Put id first, model after.
|
@KKamaa Thanks a lot for migrating this. There a few modifications that would be nice as the OCA standards and guidelines have evolved (and improved) since the module was written. |
|
Made a few fixes too based on your comments and some fixes hope its ok now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After request for changes on the last PR, I added the MIG of trp_external_user for v13.0 @NL66278