Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Catalan translation to 2.6.0 #8

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pacoriviere
Copy link

It's my first contribution to GiHub. Hope I did it right
Ready to use.
You can see it running here: http://twcaclassic.tiddlyspot.com/#CatalanLingo

pacoriviere added 3 commits May 17, 2020 20:59
Two words changed
Change a name button in GettingStarted instructions to make it consistent with the real button name.
@YakovL
Copy link
Contributor

YakovL commented May 17, 2020

Hello Paco,

congratulations, looks like you've done a great job! I've never reviewed code in the translations repository, so it make take some time to check if everything is alright, but I'm glad to see this contribution.

Couple of questions:

  • any particular reason why for 2.6.0? The latest version is 2.9.2 already..
  • are you aware of the current TiddlyWiki Classic forum? https://groups.google.com/forum/#!forum/tiddlywikiclassic May be somebody from there uses Catalan too, so if you announce your proposal somebody may be interested or even review it

Best regards,
Yakov.

@pacoriviere
Copy link
Author

pacoriviere commented May 17, 2020 via email

@pacoriviere
Copy link
Author

pacoriviere commented May 17, 2020 via email

pacoriviere added 4 commits May 18, 2020 00:33
Corrected a misspelled link
All previous versions of CatalanLingo or locale.ca with some detail
Added a link in GettingStarted to the source code
Correct typing errors
@YakovL
Copy link
Contributor

YakovL commented May 22, 2020

Hello Paco,

It's 2.6.0 as it is a translation of this one:
https://github.com/TiddlyWiki/translations/blob/master/locales/core/en/locale.en.js

right, thanks for pointing this outdated one. You can take a look at the output of

git diff 969f476792452d711d5d1670015bf58120bd9930.. -- js/Lingo.js

to see what changed since 2.6.2 (I don't have the commit hash corresponding to 2.6.0 at the moment). Actually, it's ok to propose a translation for 2.6.0 too, but would definitely be nice to have a translation for the latest version as well.

Another note: I've noticed you added a donation link to the default MainMenu. While I think this is somewhat fair to allow such thing since this file wouldn't appear without you, I have to also note that if somebody proposes a PR which makes some changes and removes such links (or for instance, adds a localization for a newer version based on your translation but without such links), I can't really reject that too if they propose some valuable changes. Afterall, a good translation just translates the interface and suggestions to donate should better be elsewhere (for instance, in readme.md, that will be shown to a user that opens the folder on github containing it). What do you think?

Other than that, this seems to be ready to be merged.

As I saw this post from you in the group:
https://groups.google.com/forum/#!searchin/tiddlywikiclassic/tiddlyspot%7Csort:date/tiddlywikiclassic/qy_CS4G-DZ0/Se5jUnz1AgAJ
about the same problem I have in my http://twcaclassic.tiddlyspot.com/
TiddlyWiki classic in Catalan site, I decided to explain you my problem

I guess, it's better to discuss in the google group (especially because Kristjan has the same problem, although he didn't explain the scenario that reproduces the issue). So if it's ok to you, reply to my notes and questions below there.

I was able to update to the 2.6.5 version, but did not find how to go further to 2.9.2
The embedded upgrade system in the backstage points to a nonexistent tiddlyspace site.

Again, since I'm not using TiddlySpot much, if you help me to reproduce the issue, I'll probably be able to help you fix it (since I've modernized it in versions 2.9.1 and 2.9.2, I know the internals somewhat well, but that doesn't apply to TiddlySpot). Ideally, explain both how you updated from 2.6.0? to 2.6.5 and what you tried to update from 2.6.5 to 2.9.2 and how that failed.

I also tried to upload an empty 2.9.2 downloaded the way Simon Baird suggested me, but was unable to do it. I always get the file saved to my disk.

Again, I don't know what Simon suggested you (which would be nice to know to reproduce the issue) and also I wonder how (and how long ago) you contacted him, because I failed to do so when I wanted to help another TiddlySpot user.

I tried both with the savetiddlers plugins installed and disabled in my Firefox. I also tried to uninstall savetiddlers, restart firefox and again the same problem. I installed again savetiddlers and the same. I also tried with Chrome with the same luck.

SaveTiddlers is used for saving TW on local disk, so it's no surprise it didn't help with any issue on TiddlySpot.

I read all tiddlysot faqs and most of the classic.tiddlywiki.com and found not any solution nor clear instructions to upsate in tiddyspot.

Yeah, if we deal with your case, it will be worth to add some docs on that. Again, TS is quite outdated and since currently I have no way to discuss this with Simon, I can only update docs on classic.tiddlywiki.com and not on TS for now.

Best regards,
Yakov.

Notes to myself:

@YakovL
Copy link
Contributor

YakovL commented May 22, 2020

PS ok, I can see there's actually more modifications of the text that go beyond translating, and the following one is potentially harmful at the moment:

In general, it's not a good idea to change texts in a translation without proposing changes in TW core. Will be nice if you change the texts in PR accordingly and create a PR to the core.

But your idea to extend GettingStarted with more useful links on setting up and learning is absolutely reasonable, I'm considering that too, so I'll definitely help you with updating TW core as well.

@pacoriviere
Copy link
Author

pacoriviere commented May 23, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants