Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type return incorrectly inst an object #784

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

spencerseale
Copy link
Contributor

@spencerseale spencerseale commented Oct 28, 2024

The type hint for the return instantiates a dataframe rather than just hints. This doesn't really cause an issue, but does cause that dataframe to be created whenever importing tiledbvcf do to this module being imported in top-level __init__.py

@spencerseale spencerseale self-assigned this Oct 28, 2024
@Shelnutt2
Copy link
Member

Please add a description to the PR.

@spencerseale spencerseale requested a review from gspowley October 29, 2024 14:46
Copy link
Member

@gspowley gspowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spencerseale.

@gspowley gspowley merged commit 8f148a5 into main Oct 29, 2024
12 of 13 checks passed
@gspowley gspowley deleted the spencerseale/hotfix/typereturn branch October 29, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants