Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for recent Zig 0.12, use .NET 6.0 #18

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

vancluever
Copy link
Contributor

This commit updates the repo to build with more recent versions of Zig 0.12, namely updating for semantic changes, e.g. enforcing const when values are not mutated, build API changes, generalization of readInt and writeInt, etc. This also updates the zig-args and parser-toolkit dependencies to accommodate.

Additionally, this updates svg2tvgt to build with .NET 6.0 versus 5.0, which is EOL and has been removed out of nixpkgs. This built without any other changes necessary.

@vancluever
Copy link
Contributor Author

@MasterQ32 just FYI I don't think the changes to build.zig are backwards compatible as the build is failing here when I try it with Zig 0.11:

build.zig:94:34: error: type '?[]const u8' does not support struct initialization syntax
    generate_ground_truth.cwd = .{ .cwd_relative = b.cache_root.path.? };
                                ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Happy to hold off on this until there's a release if that's what you want to do and just maintain it on this end. I'm not too sure if there's a backwards compatible way to do these specific parts of the build step too.

Cheers!

@ikskuh
Copy link

ikskuh commented Dec 22, 2023

Can you split the PR into two parts?

One for stuff that works with 0.11, and one for 0.12-xxx stuff, you can target the zig-master branch for this PR then

@vancluever vancluever changed the base branch from main to zig-master December 23, 2023 03:46
@vancluever
Copy link
Contributor Author

@MasterQ32 changed the base on this one to zig-master, will just put in a PR to update the .NET on the converter so that it builds without issue. I think pretty much everything here depends on Zig master now, even with the build.zig file reverted there are a ton of build issues surrounding readInt/writeInt, so I'm guessing that changed recently too.

@vancluever vancluever force-pushed the zig-0-12 branch 2 times, most recently from 2a8e89f to ade516d Compare December 23, 2023 19:04
@vancluever
Copy link
Contributor Author

vancluever commented Dec 23, 2023

Updated - added the missed line back in the README mentioned in #19 (comment) and switched the Zig version in the workflow back to master (the default). .NET has been updated to 6.0 as well. Also rebased to address conflicts.

This commit updates the repo to build with more recent versions of Zig
0.12, namely updating for semantic changes, e.g. enforcing const when
values are not mutated, build API changes, generalization of readInt
and writeInt, etc. This also updates the zig-args and parser-toolkit
dependencies to accommodate.

Additionally, this updates svg2tvgt to build with .NET 6.0 versus 5.0,
which is EOL and has been removed out of nixpkgs. This built without any
other changes necessary.
@ikskuh ikskuh merged commit e12ef5b into TinyVG:zig-master Dec 24, 2023
@vancluever vancluever deleted the zig-0-12 branch December 25, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants