Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mockNimEnabledProject mocking function #17

Closed
wants to merge 4 commits into from
Closed

Adding mockNimEnabledProject mocking function #17

wants to merge 4 commits into from

Conversation

dmartinol
Copy link
Collaborator

@dmartinol dmartinol commented Oct 7, 2024 •
edited
Loading

1st Comment:

[andrewballantyne] I imagine this belgons in the mocks for NIM Resource, no?

Link

2nd comment:

We should definitely be using page objects and not being explicit about test ids like this. cy.findByTestId for instance is also available

Link

lokeshrangineni and others added 4 commits October 4, 2024 18:18
@lokeshrangineni
incorporating code review fix. (opendatahub-io#16)
97b4f0e
@dmartinol
adding mockNimEnabledProject mocking function
731dc81 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
adding mockNimEnabledProject mocking function
e75c5ce 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
adding functions to navigate the models table
861cc1e 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@TomerFi TomerFi force-pushed the review-fix branch 2 times, most recently from 922d5d5 to 07877c6 Compare October 7, 2024 22:13
@TomerFi
Copy link
Owner

TomerFi commented Oct 7, 2024

Handled in #18 .

@TomerFi TomerFi closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmartinol @TomerFi @lokeshrangineni