-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Decapodes integration: domains, meshes, initial conditions, plot variables #283
Conversation
This latest push anticipates more integrations with AlgebraicJuliaService more and, concretely, generalizes some code from the Decapodes integration. AlgebraicJuliaService specifies integrations in an While I do not think this is entirely complete, I've
I'd like to generalize the methods in |
Thanks @quffaro! I like this reorganization and refactor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor is looking good, Matt! I know its WIP but I left some comments.
packages/algjulia-service/src/decapodes-service/DecapodesService.jl
Outdated
Show resolved
Hide resolved
packages/algjulia-service/src/decapodes-service/DecapodesService.jl
Outdated
Show resolved
Hide resolved
packages/algjulia-service/src/decapodes-service/DecapodesService.jl
Outdated
Show resolved
Hide resolved
packages/algjulia-service/src/decapodes-service/initial_conditions.jl
Outdated
Show resolved
Hide resolved
remove comment fix dumb
bea705c
to
8eb4bac
Compare
remove System reference in tsx replace plotvars with uuids in test json trying to get one-plotvar tests running again woo tests pass incl twovar
wip haven't tested but precompiles successfully
wip need to test taylor vortex ics wip ns sim seems to work julia-side
8eb4bac
to
e4af515
Compare
We can now do the Navier-Stokes vorticity equation in addition to the diffusion/heat equation. To accomplish this, we had to generalize the frontend support and Julia interop in several directions. A Decapodes simulation now analysis now requires that you specifiy:
The code is a quite raw in certain places and will need to be cleaned up later.