Json io #332
Json io #332
Conversation
There was a problem hiding this comment.
I've put this in components and export in util because export doesn't actually build a component but it needs to be used by model_menu, diagram_menu, and analysis_menu. Not sure if that's the right file structure.
| @@ -48,7 +51,13 @@ export function DiagramMenuItems(props: { | |||
| navigate(`/diagram/${newRef}`); | |||
| }; | |||
|
|
|||
| return ( | |||
| //Can this be less repetitive? | |||
There was a problem hiding this comment.
i.e. I'm wondering whether we should have an overarching Menu type that extends to DiagramMenu etc. Seems like a fair amount of duplicated boilerplate otherwise.
| return ( | ||
| //Can this be less repetitive? | ||
| const onDownloadJSON = (diagram: DiagramDocument) => { | ||
| downloadJson({ data: JSON.stringify(diagram), filename: `${diagram.name}.json` }); |
There was a problem hiding this comment.
The straight stringify of a diagram contains the Automerge hash of the diagram's model. What this means is that this simplest possible implementation has the behavior that if you download a diagram D in model M and then re-upload it, you get a diagram D' in the same model M. I think this is plausible behavior but worth thinking over.
| } | ||
|
|
||
| export const JsonImport: Component<Props> = (props) => { | ||
| const [error, setError] = createSignal<string | null>(null); |
There was a problem hiding this comment.
This reactive error isn't currently being used. I'm not sure whether this is the paradigm we want here or, if so, quite how best to make use of it.
|
I've added some css for the import menu. I was hoping to make the text box auto-widen after pasting in json but couldn't quite figure out the right way to do this, so it just gets taller at the moment. I suppose it doesn't matter much, people aren't likely to be looking closely at their raw JSON. Possibly the ideal solution would be to have an in-client JSON parser display the pasted JSON nicely formatted? But it seems pretty unimportant. |
This PR implements the ability to download a JSON dump of a model or a diagram and to upload it back via either the file browser or copy-paste.
A little skeleton code is present for analyses but there are design questions there and I would guess we should just merge this without worrying about analyses yet.
TODO: