Merge pull request #95 from Trendyol/cardinputview/fixCvvInfoDesign

CardInputView Cvv Info design fix
Trendyol · Mar 3, 2022 · 3733463 · 3733463
2 parents f6ef150 + 9f4a3d6
commit 3733463
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/buildSrc/src/main/kotlin/ComponentVersions.kt b/buildSrc/src/main/kotlin/ComponentVersions.kt
@@ -6,7 +6,7 @@ object ComponentVersions {
     const val imageSliderVersion = "1.0.8"
     const val phoneNumberVersion = "1.0.2"
     const val dialogsVersion = "1.3.1"
-    const val cardInputViewVersion = "1.2.0"
+    const val cardInputViewVersion = "1.2.1"
     const val quantityPickerViewVersion = "1.2.5"
     const val timelineViewVersion = "1.0.0"
     const val touchDelegatorVersion = "1.0.0"

diff --git a/libraries/card-input-view/README.md b/libraries/card-input-view/README.md
@@ -1,7 +1,7 @@
 
 <img src="https://raw.githubusercontent.com/Trendyol/android-ui-components/master/images/card-input-view-1.png" width="240"/> <img src="https://raw.githubusercontent.com/Trendyol/android-ui-components/master/images/card-input-view-2.png" width="240"/>
 
-$cardInputViewVersion = card-input-view-1.1.2 [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
+$cardInputViewVersion = card-input-view-1.2.1 [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
 
 ## CardInputView  
 CardInputView is custom view for Master or Visa debit/credit card inputs. It can verify card number, expire date and CVV for you.

diff --git a/libraries/card-input-view/src/main/res/drawable/shape_card_input_cvv_info_background.xml b/libraries/card-input-view/src/main/res/drawable/shape_card_input_cvv_info_background.xml
@@ -6,5 +6,5 @@
 
     <stroke
         android:width="@dimen/civ_stroke_width"
-        android:color="@android:color/darker_gray" />
+        android:color="@color/civ_cvv_info_border_color" />
 </shape>
diff --git a/libraries/card-input-view/src/main/res/values/colors.xml b/libraries/card-input-view/src/main/res/values/colors.xml
@@ -6,4 +6,5 @@
     <color name="civ_error_background">#f6dde1</color>
     <color name="civ_error_stroke">#d0021b</color>
     <color name="civ_cvv_info_background">#ffffff</color>
+    <color name="civ_cvv_info_border_color">#e5e5e5</color>
 </resources>
diff --git a/libraries/card-input-view/src/main/res/values/dimens.xml b/libraries/card-input-view/src/main/res/values/dimens.xml
@@ -7,7 +7,7 @@
 
     <dimen name="civ_height_input_field">40dp</dimen>
     <dimen name="civ_width_expiry_cvv_field">80dp</dimen>
-    <dimen name="civ_size_cvv_info">30dp</dimen>
+    <dimen name="civ_size_cvv_info">28dp</dimen>
     <dimen name="civ_stroke_width">0.5dp</dimen>
     <dimen name="civ_divider_width">0.5dp</dimen>
     <dimen name="civ_radius">1.5dp</dimen>