CSL-12 - PCA - Added new pages companies-house-number and companies-house-name #52
Conversation
…ecursor-chemicals flow
| 'declaration-check': { | ||
| mixin: 'checkbox', | ||
| validate: ['required'] | ||
| }, | ||
| 'companies-house-number': { | ||
| isPageHeading: 'true', | ||
| mixin: 'radio-group', | ||
| validate: ['required'], |
There was a problem hiding this comment.
I propose placing fields related to the two other flows before the main flow, as they occur first if you make choices so you have to fill them in. I suppose that means that for each file in this PR where something is added here it should go at the top of the list instead of the bottom
What do you think @dk4g @vinodhasamiyappanHO @RobertMcCann
There was a problem hiding this comment.
Agree on this, this will help with quick navigation
| @@ -0,0 +1,5 @@ | |||
| {{<partials-page}} | |||
| {{$page-content}} | |||
| <a href="/" class="govuk-link">Register for the licensing platform again.</a> | |||
There was a problem hiding this comment.
- Not sure how the registration design looks yet, but I suppose this href could change depending on the routes - e.g. it might go to /registration.
- Can we move the link text into the translations for this field?
There was a problem hiding this comment.
the correct link is /registration
The registration form will have a landing page /registration/ with subsequent pages with the same prefix /registration/<page>
There was a problem hiding this comment.
link text should be moved in translations, I would suggest to use buttons.json
| @@ -0,0 +1,5 @@ | |||
| {{<partials-page}} | |||
| {{$page-content}} | |||
| <a href="/" class="govuk-link">Register for the licensing platform again.</a> | |||
There was a problem hiding this comment.
the correct link is /registration
The registration form will have a landing page /registration/ with subsequent pages with the same prefix /registration/<page>
| @@ -0,0 +1,5 @@ | |||
| {{<partials-page}} | |||
| {{$page-content}} | |||
| <a href="/" class="govuk-link">Register for the licensing platform again.</a> | |||
There was a problem hiding this comment.
link text should be moved in translations, I would suggest to use buttons.json
What?
CSL-12 - Adds the configuration and files required to display the "companies-house-number and companies-house-name" pages
How?
Testing?
Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit