Update the way wl dates are parsed to a string. #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A leading 0 must be applied to dates otherwise the fuzzy matching GTAS
uses has an error parsing dates from watchlist items.
const day = stringDate.getDate(); // use getDate(). getDay() returns
the day of the week
const month = stringDate.getMonth() + 1; // 0 based
const year = stringDate.getFullYear();
to
const formattedDate = stringDate.getFullYear()
+ '-' + ('0' + (stringDate.getMonth()+1)).slice(-2)
+ '-' + ('0' + stringDate.getDate()).slice(-2);
return formattedDate;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
A clear and concise description of what the bug is.
Watchlist Imports Date Without 0
To Reproduce
Steps to reproduce the behavior:
Import watchlist, review wl_item database, review dob field.
Expected behavior
dob field in watchlist item has preceding 0s where appropriate.
e.g. 1982-02-02 instead of 1982-2-2
Additional context
Ticket for GUI
#654
Companion ticket in GTAS
US-CBP/GTAS#2016
A leading 0 must be applied to dates otherwise the fuzzy matching GTAS
uses has an error parsing dates from watchlist items.