Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underlying equations #3

Open
ellisonbg opened this issue Aug 11, 2020 · 4 comments
Open

Underlying equations #3

ellisonbg opened this issue Aug 11, 2020 · 4 comments

Comments

@ellisonbg
Copy link

Hi, I am working to implement this model in python, and have found that the original equations in the article:

https://jamanetwork.com/journals/jamanetworkopen/fullarticle/2768923?utm_campaign=articlepdf&utm_medium=articlepdflink&utm_source=articlepdf&utm_content=jamanetworkopen.2020.16818

have some typos. Have you found and fixed those typos. Can you summarize them (will try to extract them from the code, but easier to look at the math).

@skent259
Copy link
Collaborator

We have had some correspondence with one of the authors, Dr. David Paltiel, who admitted the typos in the appendix of the JAMA paper. He seemed confident in his calculations from the online spreadsheet, which our implementation copies. So I believe that we have fixed these typos implicitly.

It might be easier to download his spreadsheet to an excel document, unhide the calculations tab, and look at those equations to build out in python. That is the approach that we took in developing this tool, but unfortunately, it makes the code somewhat difficult to read.

I do have a list of some typos to the paper from Dr. Paltiel, but I hesitate to copy them here. Feel free to send me an email at skent259@gmail.com and I can share some additional information.

@aravamu2
Copy link
Collaborator

aravamu2 commented Aug 11, 2020

I believe that we have fixed these typos implicitly as well. Additionally, you can take a look at calculations.Rmd for a linear workflow of the implementation including calculation of the performance standards and generation of the stack area plot.

Let me know if you have any questions regarding the code. Thanks!

@ellisonbg
Copy link
Author

I have been able to extract the equations from the R code and have verified they conserve the total population. Would be good to add a note somewhere on this repo about this, as I have a feeling this model is going to see a lot of usage in the coming weeks/months.

@aravamu2
Copy link
Collaborator

Will do. Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants